Re: [PATCH] proc/fd: Remove the initialization of variables in seq_show()

2020-05-28 Thread Tao pilgrim
> > The variables{files, file} will definitely be assigned, > > I find an other specification nicer for these identifiers. > > > > so we don't need to initialize them. > > I suggest to recheck programming concerns around the handling > of the null pointer for the variable “file”. > https://git.kern

Re: [PATCH] proc/fd: Remove the initialization of variables in seq_show()

2020-05-24 Thread Markus Elfring
> The variables{files, file} will definitely be assigned, I find an other specification nicer for these identifiers. > so we don't need to initialize them. I suggest to recheck programming concerns around the handling of the null pointer for the variable “file”. https://git.kernel.org/pub/scm/l

[PATCH] proc/fd: Remove the initialization of variables in seq_show()

2020-05-23 Thread Kaitao Cheng
The variables{files, file} will definitely be assigned, so we don't need to initialize them. Signed-off-by: Kaitao Cheng --- fs/proc/fd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/proc/fd.c b/fs/proc/fd.c index 81882a13212d..6f95baf44e37 100644 --- a/fs/proc/fd.c