Re: [PATCH] proc: Convert S_ permission uses to octal

2021-02-13 Thread Alexey Dobriyan
On Fri, Feb 12, 2021 at 04:01:48PM -0600, Eric W. Biederman wrote: > Joe Perches writes: > > > Convert S_ permissions to the more readable octal. > Something like that should be able to address the readability while > still using symbolic constants. Macros are easy. I've sent a patch long time

Re: [PATCH] proc: Convert S_ permission uses to octal

2021-02-12 Thread Joe Perches
On Fri, 2021-02-12 at 17:48 -0600, Eric W. Biederman wrote: > Matthew Wilcox writes: > > On Fri, Feb 12, 2021 at 04:01:48PM -0600, Eric W. Biederman wrote: > > > Perhaps we can do something like: > > > > > > #define S_IRWX 7 > > > #define S_IRW_ 6 > > > #define S_IR_X 5 > > > #define S_IR__ 4 >

Re: [PATCH] proc: Convert S_ permission uses to octal

2021-02-12 Thread Joe Perches
On Fri, 2021-02-12 at 17:44 -0600, Eric W. Biederman wrote: > I certainly do not see sufficient consensus to go around changing code > other people maintain. Every patch by a non-maintainer that doesn't have commit rights to whatever tree is just a proposal. > My suggest has the nice property

Re: [PATCH] proc: Convert S_ permission uses to octal

2021-02-12 Thread Eric W. Biederman
Matthew Wilcox writes: > On Fri, Feb 12, 2021 at 04:01:48PM -0600, Eric W. Biederman wrote: >> Joe Perches writes: >> >> > Convert S_ permissions to the more readable octal. >> > >> > Done using: >> > $ ./scripts/checkpatch.pl -f --fix-inplace --types=SYMBOLIC_PERMS >> > fs/proc/*.[ch] >> >

Re: [PATCH] proc: Convert S_ permission uses to octal

2021-02-12 Thread Eric W. Biederman
Joe Perches writes: > On Fri, 2021-02-12 at 16:01 -0600, Eric W. Biederman wrote: >> Joe Perches writes: >> >> > Convert S_ permissions to the more readable octal. >> > >> > Done using: >> > $ ./scripts/checkpatch.pl -f --fix-inplace --types=SYMBOLIC_PERMS >> > fs/proc/*.[ch] >> > >> > No

Re: [PATCH] proc: Convert S_ permission uses to octal

2021-02-12 Thread Joe Perches
On Fri, 2021-02-12 at 16:01 -0600, Eric W. Biederman wrote: > Joe Perches writes: > > > Convert S_ permissions to the more readable octal. > > > > Done using: > > $ ./scripts/checkpatch.pl -f --fix-inplace --types=SYMBOLIC_PERMS > > fs/proc/*.[ch] > > > > No difference in generated .o files

Re: [PATCH] proc: Convert S_ permission uses to octal

2021-02-12 Thread Matthew Wilcox
On Fri, Feb 12, 2021 at 04:01:48PM -0600, Eric W. Biederman wrote: > Joe Perches writes: > > > Convert S_ permissions to the more readable octal. > > > > Done using: > > $ ./scripts/checkpatch.pl -f --fix-inplace --types=SYMBOLIC_PERMS > > fs/proc/*.[ch] > > > > No difference in generated .o

Re: [PATCH] proc: Convert S_ permission uses to octal

2021-02-12 Thread Eric W. Biederman
Joe Perches writes: > Convert S_ permissions to the more readable octal. > > Done using: > $ ./scripts/checkpatch.pl -f --fix-inplace --types=SYMBOLIC_PERMS > fs/proc/*.[ch] > > No difference in generated .o files allyesconfig x86-64 > > Link: >

[PATCH] proc: Convert S_ permission uses to octal

2021-02-12 Thread Joe Perches
Convert S_ permissions to the more readable octal. Done using: $ ./scripts/checkpatch.pl -f --fix-inplace --types=SYMBOLIC_PERMS fs/proc/*.[ch] No difference in generated .o files allyesconfig x86-64 Link: