Re: [PATCH] proc: added ept_ad flag to /proc/cpuinfo

2018-08-03 Thread Paolo Bonzini
On 02/08/2018 21:33, Peter Shier wrote: > >> > The Intel Haswell architecture has an EPT feature whereby the access & >> > dirty bits in EPT entries are updated without taking a guest exit. >> >> Why would this be Haswell specific? >> >> Aside of that I don't see what this has to do with exits. Fr

Re: [PATCH] proc: added ept_ad flag to /proc/cpuinfo

2018-08-03 Thread Thomas Gleixner
Peter, On Thu, 2 Aug 2018, Peter Shier wrote: > Thank you Thomas. I missed what I think is your fundamental point > regarding duplication created by this patch between CPU feature bits > and KVM's consumption of the IA32_VMX_EPT_VPID_CAP MSR. > > Should all the features in this MSR be exposed via

Re: [PATCH] proc: added ept_ad flag to /proc/cpuinfo

2018-08-02 Thread Peter Shier
Thank you Thomas. I missed what I think is your fundamental point regarding duplication created by this patch between CPU feature bits and KVM's consumption of the IA32_VMX_EPT_VPID_CAP MSR. Should all the features in this MSR be exposed via CPU feature bits and should KVM consume only from there

Re: [PATCH] proc: added ept_ad flag to /proc/cpuinfo

2018-08-01 Thread Thomas Gleixner
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? On Wed, 1 Aug 2018, Peter Shier wrote: > Thank you Thomas. Wording issues understood and will post a new patch > with updat

Re: [PATCH] proc: added ept_ad flag to /proc/cpuinfo

2018-08-01 Thread Peter Shier
k would be generally useful and I will be careful from now on to remove any wording that is not publicly relevant. On Mon, Jul 30, 2018 at 3:12 PM Thomas Gleixner wrote: > > On Mon, 30 Jul 2018, Peter Shier wrote: > > > Subject: [PATCH] proc: added ept_ad flag to /proc/cpuinfo > > T

Re: [PATCH] proc: added ept_ad flag to /proc/cpuinfo

2018-07-30 Thread Thomas Gleixner
On Mon, 30 Jul 2018, Peter Shier wrote: > Subject: [PATCH] proc: added ept_ad flag to /proc/cpuinfo The 'proc:' prefix is misleading here. x86/cpufeatures is the right choice. The /proc/cpuinfo display is a side effect. Also please avoid 'added'. Changelogs should be wri

[PATCH] proc: added ept_ad flag to /proc/cpuinfo

2018-07-30 Thread Peter Shier
From: Peter Feiner The Intel Haswell architecture has an EPT feature whereby the access & dirty bits in EPT entries are updated without taking a guest exit. This patch adds the "ept_ad" flag to /proc/cpuinfo if this feature is available. Signed-off-by: Peter Feiner Signed-off-by: Peter Shier R