Re: [PATCH] proc: do not allow negative offsets on /proc//environ

2012-07-23 Thread Oleg Nesterov
Hi Djalal, On 07/23, Djalal Harouni wrote: > > Hi Oleg, > > On Sun, Jul 22, 2012 at 10:00:49PM +0200, Oleg Nesterov wrote: > > > > Probablt the patch makes sense, but I can't understand the changelog... > > > > > Allowing negative offsets on /proc//environ can turn it to act like > > >

Re: [PATCH] proc: do not allow negative offsets on /proc//environ

2012-07-22 Thread Djalal Harouni
Hi Oleg, On Sun, Jul 22, 2012 at 10:00:49PM +0200, Oleg Nesterov wrote: > On 07/22, Djalal Harouni wrote: > > > > __mem_open() which is called by both /proc//environ and > > /proc//mem ->open() handlers will allow the use of negative offsets. > > /proc//mem has negative offsets but not

Re: [PATCH] proc: do not allow negative offsets on /proc//environ

2012-07-22 Thread Oleg Nesterov
On 07/22, Djalal Harouni wrote: > > __mem_open() which is called by both /proc//environ and > /proc//mem ->open() handlers will allow the use of negative offsets. > /proc//mem has negative offsets but not /proc//environ. Probablt the patch makes sense, but I can't understand the changelog... >

[PATCH] proc: do not allow negative offsets on /proc//environ

2012-07-22 Thread Djalal Harouni
__mem_open() which is called by both /proc//environ and /proc//mem ->open() handlers will allow the use of negative offsets. /proc//mem has negative offsets but not /proc//environ. Allowing negative offsets on /proc//environ can turn it to act like /proc//mem. A negative offset will pass the