Re: [PATCH] proc: extend /proc//fdinfo/

2008-02-11 Thread Eugene Teo
Hi Motohiro-san, > In general, I think this patch isn't wrong idea. > but it shuld be brush up more, may be. Thanks. > > kerndev: ~/code/kernel# cat /proc/`pgrep pickup`/fdinfo/6 > > mode: 0622 > > I think this is inode attribute, but not fd attribute. Yes, it is an inode attribute. > > de

Re: [PATCH] proc: extend /proc//fdinfo/

2008-02-11 Thread Eugene Teo
/fd/ Thanks for the review. I agree that some of the information can be omitted since it can be accessed using stat and readlink. I still think it is useful to have ino in the output though. Here's the updated patch: [PATCH] proc: extend /proc//fdinfo/ This patch extends /proc//fdinfo/ to r

Re: [PATCH] proc: extend /proc//fdinfo/

2008-02-11 Thread KOSAKI Motohiro
Hi Eugene In general, I think this patch isn't wrong idea. but it shuld be brush up more, may be. > kerndev: ~/code/kernel# cat /proc/`pgrep pickup`/fdinfo/6 > mode: 0622 I think this is inode attribute, but not fd attribute. > dev:253,0 > ino:21463057 may be useful, agreed with you

Re: [PATCH] proc: extend /proc//fdinfo/

2008-02-11 Thread Miklos Szeredi
On Sat, 2008-02-09 at 20:01 +0800, Eugene Teo wrote: > This patch extends /proc//fdinfo/ to report information about open > files, and pathname. This information can be useful to know when debugging an > application. > > For each file descriptor, the information is provided in the following forma

[PATCH] proc: extend /proc//fdinfo/

2008-02-09 Thread Eugene Teo
This patch extends /proc//fdinfo/ to report information about open files, and pathname. This information can be useful to know when debugging an application. For each file descriptor, the information is provided in the following format: kerndev: ~/code/kernel# cat /proc/`pgrep pickup`/fdinfo/6 mo