[PATCH] proc: move proc mount options out of pid_namespace

2013-05-25 Thread Stephen Mell
From: Stephen Mell hide_pid and pid_gid are proc mount options whose values are stored in the pid_namespace struct. As a result, if one mounts proc again for the same PID namespace with different mount options, all mounts for that PID namespace will be affected. This seems undesirable. This pa

Re: [PATCH] proc: move proc mount options out of pid_namespace

2013-05-24 Thread Gu Zheng
On 05/24/2013 05:35 PM, Stephen Mell wrote: > On Friday, May 24, 2013 17:14:13 Gu Zheng wrote: > >> One fuzzy way in my mind, I'm not sure whether it's OK, but we can discuss >> it. >> Split hide_pid, pid_gid, and proc_self from pid_namespace, and create struct >> proc_sb_info(maybe the name "p

Re: [PATCH] proc: move proc mount options out of pid_namespace

2013-05-24 Thread Stephen Mell
On Friday, May 24, 2013 17:14:13 Gu Zheng wrote: > One fuzzy way in my mind, I'm not sure whether it's OK, but we can discuss it. > Split hide_pid, pid_gid, and proc_self from pid_namespace, and create struct > proc_sb_info(maybe the name "proc_mount_info" is better). > And create a new list dom

Re: [PATCH] proc: move proc mount options out of pid_namespace

2013-05-24 Thread Gu Zheng
Hi Stephen, On 05/24/2013 12:29 PM, Stephen Mell wrote: > Gu, > > On Friday, May 24, 2013 11:03:31 Gu Zheng wrote: >> Hi Stephen, >> >> On 05/24/2013 07:32 AM, Stephen Mell wrote: >> >>> On Thursday, May 23, 2013 18:20:57 Gu Zheng wrote: >>> Here it'll create a new proc sb instance which ho

Re: [PATCH] proc: move proc mount options out of pid_namespace

2013-05-23 Thread Stephen Mell
Gu, On Friday, May 24, 2013 11:03:31 Gu Zheng wrote: > Hi Stephen, > > On 05/24/2013 07:32 AM, Stephen Mell wrote: > > > On Thursday, May 23, 2013 18:20:57 Gu Zheng wrote: > > > >> Here it'll create a new proc sb instance which holds the same context as > >> the old ones > >> each time we moun

Re: [PATCH] proc: move proc mount options out of pid_namespace

2013-05-23 Thread Gu Zheng
Hi Stephen, On 05/24/2013 07:32 AM, Stephen Mell wrote: > On Thursday, May 23, 2013 18:20:57 Gu Zheng wrote: > >> Here it'll create a new proc sb instance which holds the same context as the >> old ones >> each time we mount proc though in the same PID namespace, won't it? > I believe so. But t

Re: [PATCH] proc: move proc mount options out of pid_namespace

2013-05-23 Thread Stephen Mell
On Thursday, May 23, 2013 18:20:57 Gu Zheng wrote: > Here it'll create a new proc sb instance which holds the same context as the > old ones > each time we mount proc though in the same PID namespace, won't it? I believe so. But this is the point, right? They won't be identical if different moun

Re: [PATCH] proc: move proc mount options out of pid_namespace

2013-05-23 Thread Gu Zheng
Hi Stephen, Refer to following inline comments. Thanks, Gu On 05/23/2013 04:05 PM, Stephen Mell wrote: > From: Stephen Mell > > hide_pid and pid_gid are proc mount options whose values are stored in the > pid_namespace struct. As a result, if one mounts proc again for the same PID >

[PATCH] proc: move proc mount options out of pid_namespace

2013-05-23 Thread Stephen Mell
From: Stephen Mell hide_pid and pid_gid are proc mount options whose values are stored in the pid_namespace struct. As a result, if one mounts proc again for the same PID namespace with different mount options, all mounts for that PID namespace will be affected. This seems undesirable. This pa