Re: [PATCH] proc_sysclt: fix oops caused by incorrect command parameters.

2021-01-07 Thread Kees Cook
On Thu, Jan 07, 2021 at 02:14:18PM +0800, Xiaoming Ni wrote: > On 2021/1/7 7:46, Kees Cook wrote: > > subject typo: "sysclt" -> "sysctl" > > > > On Thu, Dec 24, 2020 at 03:42:56PM +0800, Xiaoming Ni wrote: > > > [...] > > > + if (!val) > > > + return 0; > > > + > > > if

Re: [PATCH] proc_sysclt: fix oops caused by incorrect command parameters.

2021-01-06 Thread Xiaoming Ni
On 2021/1/7 7:46, Kees Cook wrote: subject typo: "sysclt" -> "sysctl" On Thu, Dec 24, 2020 at 03:42:56PM +0800, Xiaoming Ni wrote: The process_sysctl_arg() does not check whether val is empty before invoking strlen(val). If the command line parameter () is incorrectly configured and val is

Re: [PATCH] proc_sysclt: fix oops caused by incorrect command parameters.

2021-01-06 Thread Kees Cook
subject typo: "sysclt" -> "sysctl" On Thu, Dec 24, 2020 at 03:42:56PM +0800, Xiaoming Ni wrote: > The process_sysctl_arg() does not check whether val is empty before > invoking strlen(val). If the command line parameter () is incorrectly > configured and val is empty, oops is triggered. > >

ping //Re: [PATCH] proc_sysclt: fix oops caused by incorrect command parameters.

2021-01-03 Thread Xiaoming Ni
ping On 2020/12/24 15:42, Xiaoming Ni wrote: The process_sysctl_arg() does not check whether val is empty before invoking strlen(val). If the command line parameter () is incorrectly configured and val is empty, oops is triggered. For example, "hung_task_panic=1" is incorrectly written as

[PATCH] proc_sysclt: fix oops caused by incorrect command parameters.

2020-12-23 Thread Xiaoming Ni
The process_sysctl_arg() does not check whether val is empty before invoking strlen(val). If the command line parameter () is incorrectly configured and val is empty, oops is triggered. For example, "hung_task_panic=1" is incorrectly written as "hung_task_panic". log: Kernel command