Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

2015-09-01 Thread Geoff Levand
On Tue, 2015-09-01 at 11:21 +0100, Colin King wrote: > On the unlikely event that drv is null, the current code will > perform a null pointer dereference with it when printing a dev_dbg > message. Instead, the BUG_ON check on drv should be performed > before we emit the dev_dbg message. > >

Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

2015-09-01 Thread Geert Uytterhoeven
Hi Colin, On Tue, Sep 1, 2015 at 12:38 PM, Colin Ian King wrote: > On 01/09/15 11:35, Geert Uytterhoeven wrote: >> On Tue, Sep 1, 2015 at 12:21 PM, Colin King wrote: >>> On the unlikely event that drv is null, the current code will >>> perform a null pointer dereference with it when printing a

Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

2015-09-01 Thread Colin Ian King
On 01/09/15 11:35, Geert Uytterhoeven wrote: > Hi Colin, > > On Tue, Sep 1, 2015 at 12:21 PM, Colin King wrote: >> On the unlikely event that drv is null, the current code will >> perform a null pointer dereference with it when printing a dev_dbg >> message. Instead, the BUG_ON check on drv

Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

2015-09-01 Thread Geert Uytterhoeven
Hi Colin, On Tue, Sep 1, 2015 at 12:21 PM, Colin King wrote: > On the unlikely event that drv is null, the current code will > perform a null pointer dereference with it when printing a dev_dbg > message. Instead, the BUG_ON check on drv should be performed > before we emit the dev_dbg message.

[PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

2015-09-01 Thread Colin King
From: Colin Ian King On the unlikely event that drv is null, the current code will perform a null pointer dereference with it when printing a dev_dbg message. Instead, the BUG_ON check on drv should be performed before we emit the dev_dbg message. Signed-off-by: Colin Ian King ---

Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

2015-09-01 Thread Geoff Levand
On Tue, 2015-09-01 at 11:21 +0100, Colin King wrote: > On the unlikely event that drv is null, the current code will > perform a null pointer dereference with it when printing a dev_dbg > message. Instead, the BUG_ON check on drv should be performed > before we emit the dev_dbg message. > >

[PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

2015-09-01 Thread Colin King
From: Colin Ian King On the unlikely event that drv is null, the current code will perform a null pointer dereference with it when printing a dev_dbg message. Instead, the BUG_ON check on drv should be performed before we emit the dev_dbg message. Signed-off-by: Colin

Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

2015-09-01 Thread Colin Ian King
On 01/09/15 11:35, Geert Uytterhoeven wrote: > Hi Colin, > > On Tue, Sep 1, 2015 at 12:21 PM, Colin King wrote: >> On the unlikely event that drv is null, the current code will >> perform a null pointer dereference with it when printing a dev_dbg >> message. Instead,

Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

2015-09-01 Thread Geert Uytterhoeven
Hi Colin, On Tue, Sep 1, 2015 at 12:21 PM, Colin King wrote: > On the unlikely event that drv is null, the current code will > perform a null pointer dereference with it when printing a dev_dbg > message. Instead, the BUG_ON check on drv should be performed > before we

Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

2015-09-01 Thread Geert Uytterhoeven
Hi Colin, On Tue, Sep 1, 2015 at 12:38 PM, Colin Ian King wrote: > On 01/09/15 11:35, Geert Uytterhoeven wrote: >> On Tue, Sep 1, 2015 at 12:21 PM, Colin King wrote: >>> On the unlikely event that drv is null, the current code will >>> perform