Re: [PATCH] pstore: Fix an overflow on 32-bit builds.

2014-06-18 Thread Matt Fleming
On Mon, 09 Jun, at 01:24:43PM, David Rientjes wrote: > On Mon, 9 Jun 2014, Andrzej Zaborowski wrote: > > > [resend] > > In generic_id the long int timestamp is multiplied by 10 and needs > > an explicit cast to u64. > > > > Without that the id in the resulting pstore filename is wrong and > >

Re: [PATCH] pstore: Fix an overflow on 32-bit builds.

2014-06-09 Thread David Rientjes
On Mon, 9 Jun 2014, Andrzej Zaborowski wrote: > [resend] > In generic_id the long int timestamp is multiplied by 10 and needs > an explicit cast to u64. > > Without that the id in the resulting pstore filename is wrong and > userspace may have problems parsing it, but more importantly files i

[PATCH] pstore: Fix an overflow on 32-bit builds.

2014-06-09 Thread Andrzej Zaborowski
[resend] In generic_id the long int timestamp is multiplied by 10 and needs an explicit cast to u64. Without that the id in the resulting pstore filename is wrong and userspace may have problems parsing it, but more importantly files in pstore can never be deleted and may fill the EFI flash (b