Re: [PATCH] pstore: Refactor compression initialization

2018-10-18 Thread Kees Cook
On Thu, Oct 18, 2018 at 10:14 AM, Joe Perches wrote: > On Wed, 2018-10-17 at 14:41 -0700, Kees Cook wrote: >> With compression initialization now separated from pstore_register(), >> there is no longer a good reason to do compression method selection >> during fs init. Instead, merge everything

Re: [PATCH] pstore: Refactor compression initialization

2018-10-18 Thread Kees Cook
On Thu, Oct 18, 2018 at 10:14 AM, Joe Perches wrote: > On Wed, 2018-10-17 at 14:41 -0700, Kees Cook wrote: >> With compression initialization now separated from pstore_register(), >> there is no longer a good reason to do compression method selection >> during fs init. Instead, merge everything

Re: [PATCH] pstore: Refactor compression initialization

2018-10-18 Thread Joe Perches
On Wed, 2018-10-17 at 14:41 -0700, Kees Cook wrote: > With compression initialization now separated from pstore_register(), > there is no longer a good reason to do compression method selection > during fs init. Instead, merge everything together into the late init. > Additionally cleans up the

Re: [PATCH] pstore: Refactor compression initialization

2018-10-18 Thread Joe Perches
On Wed, 2018-10-17 at 14:41 -0700, Kees Cook wrote: > With compression initialization now separated from pstore_register(), > there is no longer a good reason to do compression method selection > during fs init. Instead, merge everything together into the late init. > Additionally cleans up the

Re: [PATCH] pstore: Refactor compression initialization

2018-10-17 Thread Kees Cook
On Wed, Oct 17, 2018 at 9:42 PM, Sai Prakash Ranjan wrote: > On 10/18/2018 7:00 AM, Joel Fernandes wrote: > On Wed, Oct 17, 2018 at 02:41:24PM -0700, Kees Cook wrote: >>> >>> With compression initialization now separated from pstore_register(), >>> there is no longer a good reason to do

Re: [PATCH] pstore: Refactor compression initialization

2018-10-17 Thread Kees Cook
On Wed, Oct 17, 2018 at 9:42 PM, Sai Prakash Ranjan wrote: > On 10/18/2018 7:00 AM, Joel Fernandes wrote: > On Wed, Oct 17, 2018 at 02:41:24PM -0700, Kees Cook wrote: >>> >>> With compression initialization now separated from pstore_register(), >>> there is no longer a good reason to do

Re: [PATCH] pstore: Refactor compression initialization

2018-10-17 Thread Kees Cook
On Wed, Oct 17, 2018 at 6:30 PM, Joel Fernandes wrote: > On Wed, Oct 17, 2018 at 02:41:24PM -0700, Kees Cook wrote: >> With compression initialization now separated from pstore_register(), >> there is no longer a good reason to do compression method selection >> during fs init. Instead, merge

Re: [PATCH] pstore: Refactor compression initialization

2018-10-17 Thread Kees Cook
On Wed, Oct 17, 2018 at 6:30 PM, Joel Fernandes wrote: > On Wed, Oct 17, 2018 at 02:41:24PM -0700, Kees Cook wrote: >> With compression initialization now separated from pstore_register(), >> there is no longer a good reason to do compression method selection >> during fs init. Instead, merge

Re: [PATCH] pstore: Refactor compression initialization

2018-10-17 Thread Sai Prakash Ranjan
On 10/18/2018 7:00 AM, Joel Fernandes wrote: On Wed, Oct 17, 2018 at 02:41:24PM -0700, Kees Cook wrote: With compression initialization now separated from pstore_register(), there is no longer a good reason to do compression method selection during fs init. Instead, merge everything together

Re: [PATCH] pstore: Refactor compression initialization

2018-10-17 Thread Sai Prakash Ranjan
On 10/18/2018 7:00 AM, Joel Fernandes wrote: On Wed, Oct 17, 2018 at 02:41:24PM -0700, Kees Cook wrote: With compression initialization now separated from pstore_register(), there is no longer a good reason to do compression method selection during fs init. Instead, merge everything together

Re: [PATCH] pstore: Refactor compression initialization

2018-10-17 Thread Joel Fernandes
On Wed, Oct 17, 2018 at 02:41:24PM -0700, Kees Cook wrote: > With compression initialization now separated from pstore_register(), > there is no longer a good reason to do compression method selection > during fs init. Instead, merge everything together into the late init. > Additionally cleans up

Re: [PATCH] pstore: Refactor compression initialization

2018-10-17 Thread Joel Fernandes
On Wed, Oct 17, 2018 at 02:41:24PM -0700, Kees Cook wrote: > With compression initialization now separated from pstore_register(), > there is no longer a good reason to do compression method selection > during fs init. Instead, merge everything together into the late init. > Additionally cleans up

[PATCH] pstore: Refactor compression initialization

2018-10-17 Thread Kees Cook
With compression initialization now separated from pstore_register(), there is no longer a good reason to do compression method selection during fs init. Instead, merge everything together into the late init. Additionally cleans up the reporting to be more clear. Signed-off-by: Kees Cook ---

[PATCH] pstore: Refactor compression initialization

2018-10-17 Thread Kees Cook
With compression initialization now separated from pstore_register(), there is no longer a good reason to do compression method selection during fs init. Instead, merge everything together into the late init. Additionally cleans up the reporting to be more clear. Signed-off-by: Kees Cook ---