Re: [PATCH] pstore: Remove duplicate invoking of persistent_ram_zap()

2018-10-28 Thread Kees Cook
ux-kernel@vger.kernel.org >>Subject: Re: [PATCH] pstore: Remove duplicate invoking of persistent_ram_zap() > >>On Fri, Oct 26, 2018 at 4:41 AM, Peng15 Wang 王鹏 wrote: >>> From: Peng Wang >>> >>> When initialing przs with invalid data in buffer(no P

Re: [PATCH] pstore: Remove duplicate invoking of persistent_ram_zap()

2018-10-27 Thread Peng15 Wang 王鹏
>From: Kees Cook >Sent: Friday, October 26, 2018 17:44 >To: Peng15 Wang 王鹏 >Cc: an...@enomsg.org; ccr...@android.com; tony.l...@intel.com; >linux-kernel@vger.kernel.org >Subject: Re: [PATCH] pstore: Remove duplicate invoking of persist

Re: [PATCH] pstore: Remove duplicate invoking of persistent_ram_zap()

2018-10-26 Thread Kees Cook
On Fri, Oct 26, 2018 at 4:41 AM, Peng15 Wang 王鹏 wrote: > From: Peng Wang > > When initialing przs with invalid data in buffer(no PERSISTENT_RAM_SIG), > function call path is like this: > > ramoops_init_prz -> > | > |-> persistent_ram_new -> persistent_ram_post_init -> persistent_ram_zap > | > |--

[PATCH] pstore: Remove duplicate invoking of persistent_ram_zap()

2018-10-25 Thread Peng15 Wang 王鹏
From: Peng Wang When initialing przs with invalid data in buffer(no PERSISTENT_RAM_SIG), function call path is like this: ramoops_init_prz -> | |-> persistent_ram_new -> persistent_ram_post_init -> persistent_ram_zap | |--> persistent_ram_zap As we can see, persistent_ram_zap() is called twice.

[PATCH] pstore: Remove duplicate invoking of persistent_ram_zap()

2018-10-25 Thread Peng Wang
When initialing przs with invalid data in buffer(no PERSISTENT_RAM_SIG), function call path is like this: ramoops_init_prz -> | |-> persistent_ram_new -> persistent_ram_post_init -> persistent_ram_zap | |--> persistent_ram_zap As we can see, persistent_ram_zap() is called twice. We can avoid this