Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-28 Thread Madper Xie
Howdy Tony, Does this patch still need some rework? c...@redhat.com writes: > tony.l...@gmail.com writes: > >> On Wed, Oct 23, 2013 at 7:55 AM, Madper Xie wrote: >>> The "duplicate" entries won't appear in pstorefs. And a complain will be >>> print -- pstore: failed to load 76 record(s)

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-28 Thread Madper Xie
Howdy Tony, Does this patch still need some rework? c...@redhat.com writes: tony.l...@gmail.com writes: On Wed, Oct 23, 2013 at 7:55 AM, Madper Xie c...@redhat.com wrote: The duplicate entries won't appear in pstorefs. And a complain will be print -- pstore: failed to load 76 record(s)

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
tony.l...@gmail.com writes: > On Wed, Oct 23, 2013 at 7:55 AM, Madper Xie wrote: >> The "duplicate" entries won't appear in pstorefs. And a complain will be >> print -- pstore: failed to load 76 record(s) from 'efi' > > Maybe I don't quite get this - but it sounds like you have a whole lot > of

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Tony Luck
On Wed, Oct 23, 2013 at 7:55 AM, Madper Xie wrote: > The "duplicate" entries won't appear in pstorefs. And a complain will be > print -- pstore: failed to load 76 record(s) from 'efi' Maybe I don't quite get this - but it sounds like you have a whole lot of entries using up space in efivars that

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
richard.weinber...@gmail.com writes: > On Wed, Oct 23, 2013 at 4:55 PM, Madper Xie wrote: >> pstore try to find duplicate entries by check both ID, type and psi. >> They are not really enough for efi backend. dumped vars always have >> the same type, psi and ID. like follows: >>

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Richard Weinberger
On Wed, Oct 23, 2013 at 4:55 PM, Madper Xie wrote: > pstore try to find duplicate entries by check both ID, type and psi. > They are not really enough for efi backend. dumped vars always have > the same type, psi and ID. like follows: >

[PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
pstore try to find duplicate entries by check both ID, type and psi. They are not really enough for efi backend. dumped vars always have the same type, psi and ID. like follows: dump-type0-9-1-1382511508-C-cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0

[PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
pstore try to find duplicate entries by check both ID, type and psi. They are not really enough for efi backend. dumped vars always have the same type, psi and ID. like follows: dump-type0-9-1-1382511508-C-cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Richard Weinberger
On Wed, Oct 23, 2013 at 4:55 PM, Madper Xie c...@redhat.com wrote: pstore try to find duplicate entries by check both ID, type and psi. They are not really enough for efi backend. dumped vars always have the same type, psi and ID. like follows:

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
richard.weinber...@gmail.com writes: On Wed, Oct 23, 2013 at 4:55 PM, Madper Xie c...@redhat.com wrote: pstore try to find duplicate entries by check both ID, type and psi. They are not really enough for efi backend. dumped vars always have the same type, psi and ID. like follows:

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Tony Luck
On Wed, Oct 23, 2013 at 7:55 AM, Madper Xie c...@redhat.com wrote: The duplicate entries won't appear in pstorefs. And a complain will be print -- pstore: failed to load 76 record(s) from 'efi' Maybe I don't quite get this - but it sounds like you have a whole lot of entries using up space in

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
tony.l...@gmail.com writes: On Wed, Oct 23, 2013 at 7:55 AM, Madper Xie c...@redhat.com wrote: The duplicate entries won't appear in pstorefs. And a complain will be print -- pstore: failed to load 76 record(s) from 'efi' Maybe I don't quite get this - but it sounds like you have a whole