Re: [PATCH] pstore: fix crypto dependencies of 842/zstd compression

2018-12-18 Thread 廖威雄
hi , On 2018/12/17 16:16, kbuild test robot wrote: > Hi liaoweixiong, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on kees/for-next/pstore] > [also build test ERROR on v4.20-rc7 next-20181214] > [if your patch is applied to the wrong git tree, please drop us a

Re: [PATCH] pstore: fix crypto dependencies of 842/zstd compression

2018-12-17 Thread kbuild test robot
Hi liaoweixiong, Thank you for the patch! Yet something to improve: [auto build test ERROR on kees/for-next/pstore] [also build test ERROR on v4.20-rc7 next-20181214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0

Re: [PATCH] pstore: fix crypto dependencies of 842/zstd compression

2018-12-13 Thread 廖威雄
在 2018年12月13日 02:43, Kees Cook 写道: On Wed, Dec 12, 2018 at 12:24 AM liaoweixiong wrote: Reference to commit 58eb5b670747 ("pstore: fix crypto dependencies"), which fixed crypto dependencies of deflate, lzo, lz4 and lz4hc compression, but omitted 842 and newer compression zstd from commit 10

Re: [PATCH] pstore: fix crypto dependencies of 842/zstd compression

2018-12-12 Thread 廖威雄
In fast, there is no any failure while building or configuring on the newest codes. The patch of commit 58eb5b670747 ("pstore: fix crypto dependencies") makes the pstore itself select the crypto core if PSTORE_COMPRESS is set. This fixes the dependence bug at all in my tests. But this patch al

Re: [PATCH] pstore: fix crypto dependencies of 842/zstd compression

2018-12-12 Thread Kees Cook
On Wed, Dec 12, 2018 at 12:24 AM liaoweixiong wrote: > > Reference to commit 58eb5b670747 ("pstore: fix crypto dependencies"), > which fixed crypto dependencies of deflate, lzo, lz4 and lz4hc > compression, but omitted 842 and newer compression zstd from > commit 1021bcf44d0e ("pstore: add zstd co

[PATCH] pstore: fix crypto dependencies of 842/zstd compression

2018-12-12 Thread liaoweixiong
Reference to commit 58eb5b670747 ("pstore: fix crypto dependencies"), which fixed crypto dependencies of deflate, lzo, lz4 and lz4hc compression, but omitted 842 and newer compression zstd from commit 1021bcf44d0e ("pstore: add zstd compression support") Signed-off-by: liaoweixiong --- fs/pstore

Re: [PATCH] pstore: fix crypto dependencies without compression

2018-04-06 Thread Tobias Regnery
On 06.04.18, Arnd Bergmann wrote: > On Fri, Apr 6, 2018 at 8:38 AM, Tobias Regnery > wrote: > > Commit 58eb5b670747 ("pstore: fix crypto dependencies") fixed up the crypto > > dependencies but missed the case when no compression is selected. > > > > With CONFIG_PSTORE=y, CONFIG_PSTORE_COMPRESS=n

Re: [PATCH] pstore: fix crypto dependencies without compression

2018-04-06 Thread Arnd Bergmann
On Fri, Apr 6, 2018 at 8:38 AM, Tobias Regnery wrote: > Commit 58eb5b670747 ("pstore: fix crypto dependencies") fixed up the crypto > dependencies but missed the case when no compression is selected. > > With CONFIG_PSTORE=y, CONFIG_PSTORE_COMPRESS=n and CONFIG_CRYPTO=m we see > the following lin

[PATCH] pstore: fix crypto dependencies without compression

2018-04-05 Thread Tobias Regnery
Commit 58eb5b670747 ("pstore: fix crypto dependencies") fixed up the crypto dependencies but missed the case when no compression is selected. With CONFIG_PSTORE=y, CONFIG_PSTORE_COMPRESS=n and CONFIG_CRYPTO=m we see the following link error: fs/pstore/platform.o: In function `pstore_register': (

Re: [PATCH] pstore: fix crypto dependencies

2018-03-15 Thread Kees Cook
On Thu, Mar 15, 2018 at 8:34 AM, Arnd Bergmann wrote: > The new crypto API use causes some problems with Kconfig dependencies, > including this link error: > > fs/pstore/platform.o: In function `pstore_register': > platform.c:(.text+0x248): undefined reference to `crypto_has_alg' > platform.c:(.te

[PATCH] pstore: fix crypto dependencies

2018-03-15 Thread Arnd Bergmann
The new crypto API use causes some problems with Kconfig dependencies, including this link error: fs/pstore/platform.o: In function `pstore_register': platform.c:(.text+0x248): undefined reference to `crypto_has_alg' platform.c:(.text+0x2a0): undefined reference to `crypto_alloc_base' fs/pstore/pl