Re: [PATCH] pstore: fix warning about conditional locking

2016-11-16 Thread Joel Fernandes
Hi Arnd, On Wed, Nov 16, 2016 at 7:15 AM, Arnd Bergmann wrote: > gcc cannot prove that "prz->flags" remains constant over the > function, so it warns that we might restore flags that have > never been saved: > > fs/pstore/ram_core.c: In function ‘buffer_size_add’: > include/linux/spinlock.h:246:3

[PATCH] pstore: fix warning about conditional locking

2016-11-16 Thread Arnd Bergmann
gcc cannot prove that "prz->flags" remains constant over the function, so it warns that we might restore flags that have never been saved: fs/pstore/ram_core.c: In function ‘buffer_size_add’: include/linux/spinlock.h:246:3: error: ‘flags’ may be used uninitialized in this function [-Werror=maybe-