Re: [PATCH] ptp: ptp_clockmatrix: initialize variables

2020-10-13 Thread Richard Cochran
On Mon, Oct 12, 2020 at 09:07:30PM -0700, Tom Rix wrote: > calling function is a print information only function that returns void. That is fine. > I do think not adding error handling is worth it. > > I could change the return and then the calls if if you like. How about printing the version

Re: [PATCH] ptp: ptp_clockmatrix: initialize variables

2020-10-12 Thread Tom Rix
On 10/12/20 3:01 PM, Richard Cochran wrote: > On Sun, Oct 11, 2020 at 01:09:55PM -0700, t...@redhat.com wrote: >> From: Tom Rix >> >> Clang static analysis reports this representative problem >> >> ptp_clockmatrix.c:1852:2: warning: 5th function call argument >> is an uninitialized value >>

Re: [PATCH] ptp: ptp_clockmatrix: initialize variables

2020-10-12 Thread Richard Cochran
On Sun, Oct 11, 2020 at 01:09:55PM -0700, t...@redhat.com wrote: > From: Tom Rix > > Clang static analysis reports this representative problem > > ptp_clockmatrix.c:1852:2: warning: 5th function call argument > is an uninitialized value > snprintf(idtcm->version,

[PATCH] ptp: ptp_clockmatrix: initialize variables

2020-10-11 Thread trix
From: Tom Rix Clang static analysis reports this representative problem ptp_clockmatrix.c:1852:2: warning: 5th function call argument is an uninitialized value snprintf(idtcm->version, sizeof(idtcm->version), "%u.%u.%u",