Re: [PATCH] pwm: Remove a redundant error message when devm_request_and_ioremap fails

2012-08-08 Thread Thierry Reding
On Fri, Aug 03, 2012 at 09:43:54PM +0800, Axel Lin wrote: > The implementation in devm_request_and_ioremap() already shows error message, > so no need to show dev_err again if devm_request_and_ioremap() fails. > > Signed-off-by: Axel Lin > Cc: Stephen Warren > Cc: Philip, Avinash > --- Applied

Re: [PATCH] pwm: Remove a redundant error message when devm_request_and_ioremap fails

2012-08-03 Thread Stephen Warren
On 08/03/2012 07:43 AM, Axel Lin wrote: > The implementation in devm_request_and_ioremap() already shows error message, > so no need to show dev_err again if devm_request_and_ioremap() fails. I don't have any issue with this patch, but a general comment: It sure would be nice if there was some wa

[PATCH] pwm: Remove a redundant error message when devm_request_and_ioremap fails

2012-08-03 Thread Axel Lin
The implementation in devm_request_and_ioremap() already shows error message, so no need to show dev_err again if devm_request_and_ioremap() fails. Signed-off-by: Axel Lin Cc: Stephen Warren Cc: Philip, Avinash --- drivers/pwm/pwm-tegra.c|4 +--- drivers/pwm/pwm-tiecap.c |4 +---