Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-20 Thread Thierry Reding
On Thu, Mar 07, 2019 at 03:36:28PM -0700, Nathan Chancellor wrote: > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/pwm/pwm-img.c:126:13: error: variable 'timebase' is used > uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized] > > The final

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-08 Thread Uwe Kleine-König
On Fri, Mar 08, 2019 at 01:23:41PM -0800, Nick Desaulniers wrote: > On Fri, Mar 8, 2019 at 1:18 PM Uwe Kleine-König > wrote: > > > > On Fri, Mar 08, 2019 at 10:38:11AM -0800, Nick Desaulniers wrote: > > > On Fri, Mar 8, 2019 at 12:53 AM Uwe Kleine-König > > > wrote: > > > > > > > > On Thu, Mar 07

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-08 Thread Nick Desaulniers
On Fri, Mar 8, 2019 at 1:18 PM Uwe Kleine-König wrote: > > On Fri, Mar 08, 2019 at 10:38:11AM -0800, Nick Desaulniers wrote: > > On Fri, Mar 8, 2019 at 12:53 AM Uwe Kleine-König > > wrote: > > > > > > On Thu, Mar 07, 2019 at 03:36:28PM -0700, Nathan Chancellor wrote: > > > > When building with -W

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-08 Thread Uwe Kleine-König
On Fri, Mar 08, 2019 at 10:38:11AM -0800, Nick Desaulniers wrote: > On Fri, Mar 8, 2019 at 12:53 AM Uwe Kleine-König > wrote: > > > > On Thu, Mar 07, 2019 at 03:36:28PM -0700, Nathan Chancellor wrote: > > > When building with -Wsometimes-uninitialized, Clang warns: > > > > > > drivers/pwm/pwm-img.

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-08 Thread Nick Desaulniers
On Fri, Mar 8, 2019 at 12:53 AM Uwe Kleine-König wrote: > > On Thu, Mar 07, 2019 at 03:36:28PM -0700, Nathan Chancellor wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > > > drivers/pwm/pwm-img.c:126:13: error: variable 'timebase' is used > > uninitialized whenever 'if' con

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-08 Thread Nick Desaulniers
On Fri, Mar 8, 2019 at 12:58 AM Uwe Kleine-König wrote: > > Hello Nathan, > > the copy of my mail sent to clang-built-li...@googlegroups.com was not > accepted. (So I dropped this address from the recipients for this > reply.) Probably this list isn't open for non-members to post to. This > is a b

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-08 Thread Uwe Kleine-König
Hello Nathan, the copy of my mail sent to clang-built-li...@googlegroups.com was not accepted. (So I dropped this address from the recipients for this reply.) Probably this list isn't open for non-members to post to. This is a bit annoying, so I ask you to either fix that or don't add this address

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-08 Thread Uwe Kleine-König
On Thu, Mar 07, 2019 at 03:36:28PM -0700, Nathan Chancellor wrote: > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/pwm/pwm-img.c:126:13: error: variable 'timebase' is used > uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized] > > The final

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-07 Thread Nick Desaulniers
On Thu, Mar 7, 2019 at 2:36 PM Nathan Chancellor wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/pwm/pwm-img.c:126:13: error: variable 'timebase' is used > uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized] > > The final else if f

[PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-07 Thread Nathan Chancellor
When building with -Wsometimes-uninitialized, Clang warns: drivers/pwm/pwm-img.c:126:13: error: variable 'timebase' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] The final else if functions as an else; make that explicit so that Clang understands that