Re: [PATCH] pwm: stm32: fix build warning with CONFIG_DMA_ENGINE disabled

2018-06-12 Thread Arnd Bergmann
On Tue, Jun 12, 2018 at 9:25 AM, Geert Uytterhoeven wrote: >> --- a/drivers/pwm/pwm-stm32.c >> +++ b/drivers/pwm/pwm-stm32.c >> @@ -484,9 +484,7 @@ static int stm32_pwm_apply_locked(struct pwm_chip *chip, >> struct pwm_device *pwm, >> static const struct pwm_ops stm32pwm_ops = { >> .own

Re: [PATCH] pwm: stm32: fix build warning with CONFIG_DMA_ENGINE disabled

2018-06-12 Thread Geert Uytterhoeven
Hi Arnd, On Fri, May 25, 2018 at 11:09 PM Arnd Bergmann wrote: > Without dmaengine support, we get a harmless warning about an > unused function: > > drivers/pwm/pwm-stm32.c:166:12: error: 'stm32_pwm_capture' defined but not > used [-Werror=unused-function] > > Changing the #ifdef to an IS_ENABL

Re: [PATCH] pwm: stm32: fix build warning with CONFIG_DMA_ENGINE disabled

2018-06-06 Thread Lee Jones
On Wed, 06 Jun 2018, Thierry Reding wrote: > On Fri, May 25, 2018 at 11:08:30PM +0200, Arnd Bergmann wrote: > > Without dmaengine support, we get a harmless warning about an > > unused function: > > > > drivers/pwm/pwm-stm32.c:166:12: error: 'stm32_pwm_capture' defined but not > > used [-Werror=

Re: [PATCH] pwm: stm32: fix build warning with CONFIG_DMA_ENGINE disabled

2018-06-06 Thread Thierry Reding
On Fri, May 25, 2018 at 11:08:30PM +0200, Arnd Bergmann wrote: > Without dmaengine support, we get a harmless warning about an > unused function: > > drivers/pwm/pwm-stm32.c:166:12: error: 'stm32_pwm_capture' defined but not > used [-Werror=unused-function] > > Changing the #ifdef to an IS_ENABL

Re: [PATCH] pwm: stm32: fix build warning with CONFIG_DMA_ENGINE disabled

2018-05-28 Thread Fabrice Gasnier
On 05/25/2018 11:08 PM, Arnd Bergmann wrote: > Without dmaengine support, we get a harmless warning about an > unused function: > > drivers/pwm/pwm-stm32.c:166:12: error: 'stm32_pwm_capture' defined but not > used [-Werror=unused-function] > > Changing the #ifdef to an IS_ENABLED() check shuts u

[PATCH] pwm: stm32: fix build warning with CONFIG_DMA_ENGINE disabled

2018-05-25 Thread Arnd Bergmann
Without dmaengine support, we get a harmless warning about an unused function: drivers/pwm/pwm-stm32.c:166:12: error: 'stm32_pwm_capture' defined but not used [-Werror=unused-function] Changing the #ifdef to an IS_ENABLED() check shuts up that warning and is slightly nicer to read. Fixes: 53e38