Re: [PATCH] pwm: sunxi: wait for the READY bit

2017-02-20 Thread Olliver Schinagl
Hey Alexandre, Sorry for the very slow reply. We just bought a house so have been offline for 6+ weeks! On 03-01-17 17:44, Alexandre Belloni wrote: On 03/01/2017 at 16:56:16 +0100, Olliver Schinagl wrote : Hey Alexandre, I've sent several patches regarding pwm a while ago, sadly you never

Re: [PATCH] pwm: sunxi: wait for the READY bit

2017-02-20 Thread Olliver Schinagl
Hey Alexandre, Sorry for the very slow reply. We just bought a house so have been offline for 6+ weeks! On 03-01-17 17:44, Alexandre Belloni wrote: On 03/01/2017 at 16:56:16 +0100, Olliver Schinagl wrote : Hey Alexandre, I've sent several patches regarding pwm a while ago, sadly you never

Re: [PATCH] pwm: sunxi: wait for the READY bit

2017-01-03 Thread Alexandre Belloni
On 03/01/2017 at 16:56:16 +0100, Olliver Schinagl wrote : > Hey Alexandre, > > I've sent several patches regarding pwm a while ago, sadly you never > responded [0]. So I guess this is a follow up from that? > Well, we had the issue and I just had a bit of time to look at it. As I remembered you

Re: [PATCH] pwm: sunxi: wait for the READY bit

2017-01-03 Thread Alexandre Belloni
On 03/01/2017 at 16:56:16 +0100, Olliver Schinagl wrote : > Hey Alexandre, > > I've sent several patches regarding pwm a while ago, sadly you never > responded [0]. So I guess this is a follow up from that? > Well, we had the issue and I just had a bit of time to look at it. As I remembered you

Re: [PATCH] pwm: sunxi: wait for the READY bit

2017-01-03 Thread Olliver Schinagl
Hey Alexandre, I've sent several patches regarding pwm a while ago, sadly you never responded [0]. So I guess this is a follow up from that? I couldn't quickly find the resubmitted version however. Anyway, see below for my comments. On 03-01-17 15:57, Alexandre Belloni wrote: Most of the

Re: [PATCH] pwm: sunxi: wait for the READY bit

2017-01-03 Thread Olliver Schinagl
Hey Alexandre, I've sent several patches regarding pwm a while ago, sadly you never responded [0]. So I guess this is a follow up from that? I couldn't quickly find the resubmitted version however. Anyway, see below for my comments. On 03-01-17 15:57, Alexandre Belloni wrote: Most of the

[PATCH] pwm: sunxi: wait for the READY bit

2017-01-03 Thread Alexandre Belloni
Most of the call sites in the kernel are not really prepared to handle -EBUSY when calling pwm_config(). This means that they will either fail silently or fail without letting the user retry at a later time. This can be seen for example when using pwm-backlight (the most common use case for this

[PATCH] pwm: sunxi: wait for the READY bit

2017-01-03 Thread Alexandre Belloni
Most of the call sites in the kernel are not really prepared to handle -EBUSY when calling pwm_config(). This means that they will either fail silently or fail without letting the user retry at a later time. This can be seen for example when using pwm-backlight (the most common use case for this