Re: [PATCH] pwm-backlight: Pinctrl-fy

2012-11-12 Thread Pantelis Antoniou
Hi Linus, On Nov 11, 2012, at 7:26 PM, Linus Walleij wrote: > On Fri, Nov 9, 2012 at 9:06 AM, Thierry Reding > wrote: >> On Wed, Oct 31, 2012 at 05:57:27PM +0200, Pantelis Antoniou wrote: > >>> + pinctrl = devm_pinctrl_get_select_default(>dev); >>> + if (IS_ERR(pinctrl)) >>> +

Re: [PATCH] pwm-backlight: Pinctrl-fy

2012-11-12 Thread Pantelis Antoniou
Hi Linus, On Nov 11, 2012, at 7:26 PM, Linus Walleij wrote: On Fri, Nov 9, 2012 at 9:06 AM, Thierry Reding thierry.red...@avionic-design.de wrote: On Wed, Oct 31, 2012 at 05:57:27PM +0200, Pantelis Antoniou wrote: + pinctrl = devm_pinctrl_get_select_default(pdev-dev); + if

Re: [PATCH] pwm-backlight: Pinctrl-fy

2012-11-11 Thread Linus Walleij
On Fri, Nov 9, 2012 at 9:06 AM, Thierry Reding wrote: > On Wed, Oct 31, 2012 at 05:57:27PM +0200, Pantelis Antoniou wrote: >> + pinctrl = devm_pinctrl_get_select_default(>dev); >> + if (IS_ERR(pinctrl)) >> + dev_warn(>dev, "unable to select pin group\n"); >> + > > I just saw

Re: [PATCH] pwm-backlight: Pinctrl-fy

2012-11-11 Thread Linus Walleij
On Fri, Nov 9, 2012 at 9:06 AM, Thierry Reding thierry.red...@avionic-design.de wrote: On Wed, Oct 31, 2012 at 05:57:27PM +0200, Pantelis Antoniou wrote: + pinctrl = devm_pinctrl_get_select_default(pdev-dev); + if (IS_ERR(pinctrl)) + dev_warn(pdev-dev, unable to select pin

Re: [PATCH] pwm-backlight: Pinctrl-fy

2012-11-09 Thread Thierry Reding
On Wed, Oct 31, 2012 at 05:57:27PM +0200, Pantelis Antoniou wrote: > Enable pinctrl for pwm-backlight. > > Signed-off-by: Pantelis Antoniou > --- > drivers/video/backlight/pwm_bl.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/video/backlight/pwm_bl.c >

Re: [PATCH] pwm-backlight: Pinctrl-fy

2012-11-09 Thread Thierry Reding
On Wed, Oct 31, 2012 at 05:57:27PM +0200, Pantelis Antoniou wrote: Enable pinctrl for pwm-backlight. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- drivers/video/backlight/pwm_bl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [PATCH] pwm-backlight: Pinctrl-fy

2012-11-04 Thread Thierry Reding
On Wed, Oct 31, 2012 at 05:57:27PM +0200, Pantelis Antoniou wrote: [...] > diff --git a/drivers/video/backlight/pwm_bl.c > b/drivers/video/backlight/pwm_bl.c [...] > @@ -20,6 +20,8 @@ > #include > #include > #include > +#include > +#include linux/err.h is already included earlier.

Re: [PATCH] pwm-backlight: Pinctrl-fy

2012-11-04 Thread Thierry Reding
On Wed, Oct 31, 2012 at 05:57:27PM +0200, Pantelis Antoniou wrote: [...] diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c [...] @@ -20,6 +20,8 @@ #include linux/pwm.h #include linux/pwm_backlight.h #include linux/slab.h +#include linux/pinctrl/consumer.h

[PATCH] pwm-backlight: Pinctrl-fy

2012-10-30 Thread Pantelis Antoniou
Enable pinctrl for pwm-backlight. Signed-off-by: Pantelis Antoniou --- drivers/video/backlight/pwm_bl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 0c91023..f3b6194 100644 ---

[PATCH] pwm-backlight: Pinctrl-fy

2012-10-30 Thread Pantelis Antoniou
Enable pinctrl for pwm-backlight. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- drivers/video/backlight/pwm_bl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 0c91023..f3b6194 100644 ---