Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-13 Thread Arnd Bergmann
On Monday 12 October 2015 23:07:28 Robert Jarzmik wrote: > Arnd Bergmann writes: > > The z2 in particular never did, except in the powerdown handler. So if it > > is unable to wake up reliably from DEEPSLEEP, that may be a reason to use > > that flag only in the poweroff function but not during n

Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-12 Thread Robert Jarzmik
Arnd Bergmann writes: >> It looks to me the powermode should be initialized once and for all in the >> machine init code. So unless I've overseen something, I'll keep Thierry's >> patch. > > Ah, sorry. I should have looked at the link you sent. > > Thierry's patch indeed looks much nicer if that

Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-12 Thread Arnd Bergmann
On Monday 12 October 2015 20:53:50 Robert Jarzmik wrote: > Robert Jarzmik writes: > > > Arnd Bergmann writes: > > > >> The z2 machine calls pxa27x_set_pwrmode() in order to power off > >> the machine, but this function gets discarded early at boot because > >> it is marked __init, as pointed out

Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-12 Thread Robert Jarzmik
Robert Jarzmik writes: > Arnd Bergmann writes: > >> The z2 machine calls pxa27x_set_pwrmode() in order to power off >> the machine, but this function gets discarded early at boot because >> it is marked __init, as pointed out by kbuild: >> >> WARNING: vmlinux.o(.text+0x145c4): Section mismatch i

Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-12 Thread Arnd Bergmann
On Monday 12 October 2015 19:10:10 Robert Jarzmik wrote: > Arnd Bergmann writes: > > > The z2 machine calls pxa27x_set_pwrmode() in order to power off > > the machine, but this function gets discarded early at boot because > > it is marked __init, as pointed out by kbuild: > > > > WARNING: vmlinu

Re: [PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-12 Thread Robert Jarzmik
Arnd Bergmann writes: > The z2 machine calls pxa27x_set_pwrmode() in order to power off > the machine, but this function gets discarded early at boot because > it is marked __init, as pointed out by kbuild: > > WARNING: vmlinux.o(.text+0x145c4): Section mismatch in reference from the > function

[PATCH] pxa: remove incorrect __init annotation on pxa27x_set_pwrmode

2015-10-12 Thread Arnd Bergmann
The z2 machine calls pxa27x_set_pwrmode() in order to power off the machine, but this function gets discarded early at boot because it is marked __init, as pointed out by kbuild: WARNING: vmlinux.o(.text+0x145c4): Section mismatch in reference from the function z2_power_off() to the function .ini