Re: [PATCH] qcom: apr: Make apr callbacks in non-atomic context

2019-02-05 Thread Bjorn Andersson
On Thu 31 Jan 09:33 PST 2019, Srinivas Kandagatla wrote: > On 31/01/2019 16:05, Bjorn Andersson wrote: > > Sure, but we want the design to allow for that still, either in future > > upstream or by additional downstream code. > > > Yes, I agree, I don't have solution for this ATM. > It will be int

Re: [PATCH] qcom: apr: Make apr callbacks in non-atomic context

2019-01-31 Thread Srinivas Kandagatla
On 31/01/2019 16:05, Bjorn Andersson wrote: Sure, but we want the design to allow for that still, either in future upstream or by additional downstream code. Yes, I agree, I don't have solution for this ATM. It will be interesting to see how Intel handles this kind of usecase on there DSP. T

Re: [PATCH] qcom: apr: Make apr callbacks in non-atomic context

2019-01-31 Thread Bjorn Andersson
On Thu 31 Jan 02:44 PST 2019, Srinivas Kandagatla wrote: > > > On 31/01/2019 01:16, Bjorn Andersson wrote: > > On Thu 15 Nov 10:49 PST 2018, Srinivas Kandagatla wrote: > > > > > APR communication with DSP is not atomic in nature. > > > Its request-response type. Trying to pretend that these are

Re: [PATCH] qcom: apr: Make apr callbacks in non-atomic context

2019-01-31 Thread Srinivas Kandagatla
On 31/01/2019 01:16, Bjorn Andersson wrote: On Thu 15 Nov 10:49 PST 2018, Srinivas Kandagatla wrote: APR communication with DSP is not atomic in nature. Its request-response type. Trying to pretend that these are atomic and invoking apr client callbacks directly under atomic/irq context has

Re: [PATCH] qcom: apr: Make apr callbacks in non-atomic context

2019-01-30 Thread Bjorn Andersson
On Thu 15 Nov 10:49 PST 2018, Srinivas Kandagatla wrote: > APR communication with DSP is not atomic in nature. > Its request-response type. Trying to pretend that these are atomic > and invoking apr client callbacks directly under atomic/irq context has > endless issues with soundcard. It makes mo

Re: [PATCH] qcom: apr: Make apr callbacks in non-atomic context

2019-01-29 Thread Srinivas Kandagatla
Hi Andy, Could you queue this up for 5.1 cycle! We would need this to get the audio working on 820c along with WCD9335 slimbus codec! thanks, srini On 15/11/2018 18:49, Srinivas Kandagatla wrote: APR communication with DSP is not atomic in nature. Its request-response type. Trying to preten

[PATCH] qcom: apr: Make apr callbacks in non-atomic context

2018-11-15 Thread Srinivas Kandagatla
APR communication with DSP is not atomic in nature. Its request-response type. Trying to pretend that these are atomic and invoking apr client callbacks directly under atomic/irq context has endless issues with soundcard. It makes more sense to convert these to nonatomic calls. This also coverts al