Re: [PATCH] qed: fix assignment of n_rq_elems to incorrect params field

2020-07-27 Thread David Miller
From: Jason Gunthorpe Date: Mon, 27 Jul 2020 13:17:39 -0300 > On Mon, Jul 27, 2020 at 03:17:12PM +0100, Colin King wrote: >> From: Colin Ian King >> >> Currently n_rq_elems is being assigned to params.elem_size instead of the >> field params.num_elems. Coverity is detecting this as a double as

Re: [PATCH] qed: fix assignment of n_rq_elems to incorrect params field

2020-07-27 Thread Jason Gunthorpe
On Mon, Jul 27, 2020 at 03:17:12PM +0100, Colin King wrote: > From: Colin Ian King > > Currently n_rq_elems is being assigned to params.elem_size instead of the > field params.num_elems. Coverity is detecting this as a double assingment > to params.elem_size and reporting this as an usused value

Re: [PATCH] qed: fix assignment of n_rq_elems to incorrect params field

2020-07-27 Thread Colin Ian King
On 27/07/2020 15:36, Alexander Lobakin wrote: > Hi Colin, > > From: Colin King > Date: Mon, 27 Jul 2020 15:17:12 +0100 > >> From: Colin Ian King >> >> Currently n_rq_elems is being assigned to params.elem_size instead of the >> field params.num_elems. Coverity is detecting this as a double ass

Re: [PATCH] qed: fix assignment of n_rq_elems to incorrect params field

2020-07-27 Thread Alexander Lobakin
Hi Colin, From: Colin King Date: Mon, 27 Jul 2020 15:17:12 +0100 > From: Colin Ian King > > Currently n_rq_elems is being assigned to params.elem_size instead of the > field params.num_elems. Coverity is detecting this as a double assingment > to params.elem_size and reporting this as an usus

[PATCH] qed: fix assignment of n_rq_elems to incorrect params field

2020-07-27 Thread Colin King
From: Colin Ian King Currently n_rq_elems is being assigned to params.elem_size instead of the field params.num_elems. Coverity is detecting this as a double assingment to params.elem_size and reporting this as an usused value on the first assignment. Fix this. Addresses-Coverity: ("Unused val