Re: [PATCH] qedr: fix resource leak in qedr_create_qp

2020-09-11 Thread Keita Suzuki
Hi, thank you for the comment. I will fix the line break and re-post the patch Thanks, Keita 2020年9月11日(金) 4:48 Markus Elfring : > > > I will re-label the goto statements and post the patch as version 2. > > Thanks for such a positive feedback. > > > Another suggestion: > > > > Fixes: 1212767e23b

Re: [PATCH] qedr: fix resource leak in qedr_create_qp

2020-09-10 Thread Keita Suzuki
Hi, Thank you for your comment. I will re-label the goto statements and post the patch as version 2. Thanks, Keita 2020年9月10日(木) 22:24 Markus Elfring : > > > Fix this by adding a new goto label that calls qedr_free_qp_resources. > > … > > +++ b/drivers/infiniband/hw/qedr/verbs.c > … > > @@ -2165

[PATCH] qedr: fix resource leak in qedr_create_qp

2020-09-09 Thread Keita Suzuki
When xa_insert() fails, the acquired resource in qedr_create_qp should also be freed. However, current implementation does not handle the error. Fix this by adding a new goto label that calls qedr_free_qp_resources. Fixes: 1212767e23bb ("qedr: Add wrapping generic structure for qpidr and adjust i