Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device

2017-05-24 Thread Martin K. Petersen
Johannes, > When pci_enable_device() or pci_enable_device_mem() fail in > qla2x00_probe_one() we bail out but do a call to > pci_disable_device(). This causes the dev_WARN_ON() in > pci_disable_device() to trigger, as the device wasn't enabled > previously. > > So instead of taking the 'probe_out

Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device

2017-05-24 Thread Malavali, Giridhar
On 5/24/17, 8:47 AM, "Bart Van Assche" wrote: >On Tue, 2017-05-23 at 16:50 +0200, Johannes Thumshirn wrote: >> When pci_enable_device() or pci_enable_device_mem() fail in >> qla2x00_probe_one() we bail out but do a call to >> pci_disable_device(). This causes the dev_WARN_ON() in >> pci_disable

Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device

2017-05-24 Thread Bart Van Assche
On Tue, 2017-05-23 at 16:50 +0200, Johannes Thumshirn wrote: > When pci_enable_device() or pci_enable_device_mem() fail in > qla2x00_probe_one() we bail out but do a call to > pci_disable_device(). This causes the dev_WARN_ON() in > pci_disable_device() to trigger, as the device wasn't enabled > pr

Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device

2017-05-23 Thread Martin K. Petersen
Johannes, > When pci_enable_device() or pci_enable_device_mem() fail in > qla2x00_probe_one() we bail out but do a call to > pci_disable_device(). This causes the dev_WARN_ON() in > pci_disable_device() to trigger, as the device wasn't enabled > previously. > > So instead of taking the 'probe_out

[PATCH] qla2xxx: don't disable a not previously enabled PCI device

2017-05-23 Thread Johannes Thumshirn
When pci_enable_device() or pci_enable_device_mem() fail in qla2x00_probe_one() we bail out but do a call to pci_disable_device(). This causes the dev_WARN_ON() in pci_disable_device() to trigger, as the device wasn't enabled previously. So instead of taking the 'probe_out' error path we can direc