Re: [PATCH] qspinlock: no need to check return value of debugfs_create functions

2019-02-01 Thread Greg Kroah-Hartman
Sorry for the delay, got stuck with other things... On Wed, Jan 23, 2019 at 09:14:41AM +0100, Peter Zijlstra wrote: > On Tue, Jan 22, 2019 at 04:21:43PM +0100, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work

Re: [PATCH] qspinlock: no need to check return value of debugfs_create functions

2019-01-23 Thread Greg Kroah-Hartman
On Wed, Jan 23, 2019 at 09:10:18AM +, Will Deacon wrote: > On Tue, Jan 22, 2019 at 04:21:43PM +0100, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something

Re: [PATCH] qspinlock: no need to check return value of debugfs_create functions

2019-01-23 Thread Will Deacon
On Tue, Jan 22, 2019 at 04:21:43PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Peter Zijlstra > Cc: Ingo Molnar

Re: [PATCH] qspinlock: no need to check return value of debugfs_create functions

2019-01-23 Thread Peter Zijlstra
On Tue, Jan 22, 2019 at 04:21:43PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. So I've seen you do a fair number of these

[PATCH] qspinlock: no need to check return value of debugfs_create functions

2019-01-22 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Will Deacon Signed-off-by: Greg Kroah-Hartman --- kernel/locking/qspinlo