Re: [PATCH] radio-si470x.c: check-after-use

Hi, > > > Either "radio" can be NULL and this case has to be properly handled or > > > the NULL check is not required. > > > > These two lines should indeed better be inside the if statement. The patch > > for this is below. > > No, in disconnect intfdata must be valid. Any check for NULL is

Re: [PATCH] radio-si470x.c: check-after-use

Am Montag 28 Januar 2008 schrieb Tobias Lorenz: > > Either "radio" can be NULL and this case has to be properly handled or > > the NULL check is not required. > > These two lines should indeed better be inside the if statement. The patch > for this is below. No, in disconnect intfdata must be

Re: [PATCH] radio-si470x.c: check-after-use

Am Montag 28 Januar 2008 schrieb Tobias Lorenz: Either radio can be NULL and this case has to be properly handled or the NULL check is not required. These two lines should indeed better be inside the if statement. The patch for this is below. No, in disconnect intfdata must be valid.

Re: [PATCH] radio-si470x.c: check-after-use

Hi, Either radio can be NULL and this case has to be properly handled or the NULL check is not required. These two lines should indeed better be inside the if statement. The patch for this is below. No, in disconnect intfdata must be valid. Any check for NULL is wrong there.

[PATCH] radio-si470x.c: check-after-use

Hi Mauro, Hi Adrian, Adrian used the coverity checker against radio-si470x and found this: > The Coverity checker spotted the following check-after-use in > drivers/media/radio/radio-si470x.c: > > <-- snip --> > static void si470x_usb_driver_disconnect(struct usb_interface *intf) > { >

[PATCH] radio-si470x.c: check-after-use

Hi Mauro, Hi Adrian, Adrian used the coverity checker against radio-si470x and found this: The Coverity checker spotted the following check-after-use in drivers/media/radio/radio-si470x.c: -- snip -- static void si470x_usb_driver_disconnect(struct usb_interface *intf) { struct