Re: [PATCH] ramdisk driver: make rd_size non-static

2008-01-18 Thread Russell King - ARM Linux
On Thu, Jan 17, 2008 at 06:28:51PM -0800, Andrew Morton wrote: > On Fri, 18 Jan 2008 02:02:17 + Byron Bradley <[EMAIL PROTECTED]> wrote: > > > In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the > > boot tags. The replacement ramdisk driver has rd_size as static > > which

Re: [PATCH] ramdisk driver: make rd_size non-static

2008-01-18 Thread Nick Piggin
On Thu, Jan 17, 2008 at 08:39:23PM -0600, Matt Mackall wrote: > > On Thu, 2008-01-17 at 18:28 -0800, Andrew Morton wrote: > > On Fri, 18 Jan 2008 02:02:17 + Byron Bradley <[EMAIL PROTECTED]> wrote: > > > > > In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the > > > boot tags.

Re: [PATCH] ramdisk driver: make rd_size non-static

2008-01-18 Thread Nick Piggin
On Thu, Jan 17, 2008 at 08:39:23PM -0600, Matt Mackall wrote: On Thu, 2008-01-17 at 18:28 -0800, Andrew Morton wrote: On Fri, 18 Jan 2008 02:02:17 + Byron Bradley [EMAIL PROTECTED] wrote: In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the boot tags. The

Re: [PATCH] ramdisk driver: make rd_size non-static

2008-01-18 Thread Russell King - ARM Linux
On Thu, Jan 17, 2008 at 06:28:51PM -0800, Andrew Morton wrote: On Fri, 18 Jan 2008 02:02:17 + Byron Bradley [EMAIL PROTECTED] wrote: In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the boot tags. The replacement ramdisk driver has rd_size as static which causes linking

Re: [PATCH] ramdisk driver: make rd_size non-static

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 18:28 -0800, Andrew Morton wrote: > On Fri, 18 Jan 2008 02:02:17 + Byron Bradley <[EMAIL PROTECTED]> wrote: > > > In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the > > boot tags. The replacement ramdisk driver has rd_size as static > > which causes

Re: [PATCH] ramdisk driver: make rd_size non-static

2008-01-17 Thread Andrew Morton
On Fri, 18 Jan 2008 02:02:17 + Byron Bradley <[EMAIL PROTECTED]> wrote: > In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the > boot tags. The replacement ramdisk driver has rd_size as static > which causes linking to fail when ramdisk is built-in. > but... > diff --git

[PATCH] ramdisk driver: make rd_size non-static

2008-01-17 Thread Byron Bradley
In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the boot tags. The replacement ramdisk driver has rd_size as static which causes linking to fail when ramdisk is built-in. Signed-off-by: Byron Bradley <[EMAIL PROTECTED]> Cc: Nick Piggin <[EMAIL PROTECTED]> Cc: Russell King <[EMAIL

[PATCH] ramdisk driver: make rd_size non-static

2008-01-17 Thread Byron Bradley
In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the boot tags. The replacement ramdisk driver has rd_size as static which causes linking to fail when ramdisk is built-in. Signed-off-by: Byron Bradley [EMAIL PROTECTED] Cc: Nick Piggin [EMAIL PROTECTED] Cc: Russell King [EMAIL

Re: [PATCH] ramdisk driver: make rd_size non-static

2008-01-17 Thread Andrew Morton
On Fri, 18 Jan 2008 02:02:17 + Byron Bradley [EMAIL PROTECTED] wrote: In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the boot tags. The replacement ramdisk driver has rd_size as static which causes linking to fail when ramdisk is built-in. but... diff --git

Re: [PATCH] ramdisk driver: make rd_size non-static

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 18:28 -0800, Andrew Morton wrote: On Fri, 18 Jan 2008 02:02:17 + Byron Bradley [EMAIL PROTECTED] wrote: In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the boot tags. The replacement ramdisk driver has rd_size as static which causes linking to