Re: [PATCH] random: fix rdrand mix-in

2018-07-17 Thread Linus Torvalds
On Tue, Jul 17, 2018 at 2:12 PM Theodore Y. Ts'o wrote: > > I wasn't sure how quickly the HW entropy would replenish itself; I > know that on first RDRAND platforms it would effectively never fail > (as in if six of the eight cores were calling RDRAND in a tight loop > _maybe_ you could exhaust th

Re: [PATCH] random: fix rdrand mix-in

2018-07-17 Thread Theodore Y. Ts'o
On Tue, Jul 17, 2018 at 09:26:00AM -0700, Linus Torvalds wrote: > On Tue, Jul 17, 2018 at 6:54 AM Arnd Bergmann wrote: > > > > The newly added arch_get_random_int() call was done incorrectly, > > using the output only if rdrand hardware was /not/ available. The > > compiler points out that the dat

Re: [PATCH] random: fix rdrand mix-in

2018-07-17 Thread Arnd Bergmann
On Tue, Jul 17, 2018 at 6:26 PM, Linus Torvalds wrote: > On Tue, Jul 17, 2018 at 6:54 AM Arnd Bergmann wrote: >> >> The newly added arch_get_random_int() call was done incorrectly, >> using the output only if rdrand hardware was /not/ available. The >> compiler points out that the data is uniniti

Re: [PATCH] random: fix rdrand mix-in

2018-07-17 Thread Linus Torvalds
On Tue, Jul 17, 2018 at 6:54 AM Arnd Bergmann wrote: > > The newly added arch_get_random_int() call was done incorrectly, > using the output only if rdrand hardware was /not/ available. The > compiler points out that the data is uninitialized in this case: Ack. Except: > for (b

[PATCH] random: fix rdrand mix-in

2018-07-17 Thread Arnd Bergmann
The newly added arch_get_random_int() call was done incorrectly, using the output only if rdrand hardware was /not/ available. The compiler points out that the data is uninitialized in this case: drivers/char/random.c: In function 'write_pool.constprop': drivers/char/random.c:1912:11: error: 't' m