Re: [PATCH] rave-sp: Remove VLA

2018-04-26 Thread Lee Jones
> On Wed, Apr 25, 2018 at 3:31 AM Lee Jones wrote: > > > On Tue, 24 Apr 2018, Kees Cook wrote: > > > > On Mon, Apr 23, 2018 at 10:43 PM, Lee Jones > wrote: > > > > On Mon, 23 Apr 2018, Kyle Spiers wrote: > > > > > > > >> As part of the effort to remove VLAs from the kernel[1], this creates > >

Re: [PATCH] rave-sp: Remove VLA

2018-04-25 Thread Kyle Spiers
The error message is also wrong. Would "Checksum length too large" be fine? On Wed, Apr 25, 2018 at 3:31 AM Lee Jones wrote: > On Tue, 24 Apr 2018, Kees Cook wrote: > > On Mon, Apr 23, 2018 at 10:43 PM, Lee Jones wrote: > > > On Mon, 23 Apr 2018, Kyle Spiers wrote: > > > > > >> As part of the

Re: [PATCH] rave-sp: Remove VLA

2018-04-25 Thread Lee Jones
On Tue, 24 Apr 2018, Kees Cook wrote: > On Mon, Apr 23, 2018 at 10:43 PM, Lee Jones wrote: > > On Mon, 23 Apr 2018, Kyle Spiers wrote: > > > >> As part of the effort to remove VLAs from the kernel[1], this creates > >> constants for the checksum lengths of CCITT and 8B2C and changes > >> crc_calc

Re: [PATCH] rave-sp: Remove VLA

2018-04-24 Thread Kees Cook
On Mon, Apr 23, 2018 at 10:43 PM, Lee Jones wrote: > On Mon, 23 Apr 2018, Kyle Spiers wrote: > >> As part of the effort to remove VLAs from the kernel[1], this creates >> constants for the checksum lengths of CCITT and 8B2C and changes >> crc_calculated to be the maximum size of a checksum. >> >>

Re: [PATCH] rave-sp: Remove VLA

2018-04-23 Thread Lee Jones
On Mon, 23 Apr 2018, Kyle Spiers wrote: > As part of the effort to remove VLAs from the kernel[1], this creates > constants for the checksum lengths of CCITT and 8B2C and changes > crc_calculated to be the maximum size of a checksum. > > https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Kyle

Re: [PATCH] rave-sp: Remove VLA

2018-04-23 Thread Kees Cook
On Mon, Apr 23, 2018 at 1:02 PM, Kyle Spiers wrote: > As part of the effort to remove VLAs from the kernel[1], this creates > constants for the checksum lengths of CCITT and 8B2C and changes > crc_calculated to be the maximum size of a checksum. > > https://lkml.org/lkml/2018/3/7/621 > > Signed-of

[PATCH] rave-sp: Remove VLA

2018-04-23 Thread Kyle Spiers
As part of the effort to remove VLAs from the kernel[1], this creates constants for the checksum lengths of CCITT and 8B2C and changes crc_calculated to be the maximum size of a checksum. https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Kyle Spiers --- drivers/mfd/rave-sp.c | 11 +-- 1