Re: [PATCH] raw1394 : Fix hang on unload

2005-02-08 Thread Parag Warudkar
> I looked also at other 1394 drivers and all have the calls in 'bad' order. > Sure this ordering has to be reversed or it is correct and is triggering > other hidden bug ? > Quite possibly it's triggering (or is triggered by) some other bug. There is also a possibility that raw1394.c might be

Re: [PATCH] raw1394 : Fix hang on unload

2005-02-08 Thread J.A. Magallon
On 2005.02.07, [EMAIL PROTECTED] wrote: > On Sun, Feb 06, 2005 at 02:41:15PM -0500, Parag Warudkar wrote: > > I was seeing rmmod getting stuck consistently in D state while removing > > raw1394. Looking at raw1394.c:cleanup_raw1394 - the order of doing > > things seemed incorrect to me after

Re: [PATCH] raw1394 : Fix hang on unload

2005-02-08 Thread J.A. Magallon
On 2005.02.07, [EMAIL PROTECTED] wrote: On Sun, Feb 06, 2005 at 02:41:15PM -0500, Parag Warudkar wrote: I was seeing rmmod getting stuck consistently in D state while removing raw1394. Looking at raw1394.c:cleanup_raw1394 - the order of doing things seemed incorrect to me after comparing

Re: [PATCH] raw1394 : Fix hang on unload

2005-02-08 Thread Parag Warudkar
I looked also at other 1394 drivers and all have the calls in 'bad' order. Sure this ordering has to be reversed or it is correct and is triggering other hidden bug ? Quite possibly it's triggering (or is triggered by) some other bug. There is also a possibility that raw1394.c might be doing

Re: [PATCH] raw1394 : Fix hang on unload

2005-02-07 Thread hugang
On Sun, Feb 06, 2005 at 02:41:15PM -0500, Parag Warudkar wrote: > I was seeing rmmod getting stuck consistently in D state while removing > raw1394. Looking at raw1394.c:cleanup_raw1394 - the order of doing > things seemed incorrect to me after comparing other places in raw1394.c > which do the

Re: [PATCH] raw1394 : Fix hang on unload

2005-02-07 Thread hugang
On Sun, Feb 06, 2005 at 02:41:15PM -0500, Parag Warudkar wrote: I was seeing rmmod getting stuck consistently in D state while removing raw1394. Looking at raw1394.c:cleanup_raw1394 - the order of doing things seemed incorrect to me after comparing other places in raw1394.c which do the same

[PATCH] raw1394 : Fix hang on unload

2005-02-06 Thread Parag Warudkar
I was seeing rmmod getting stuck consistently in D state while removing raw1394. Looking at raw1394.c:cleanup_raw1394 - the order of doing things seemed incorrect to me after comparing other places in raw1394.c which do the same thing but with a different order. bash R running task

[PATCH] raw1394 : Fix hang on unload

2005-02-06 Thread Parag Warudkar
I was seeing rmmod getting stuck consistently in D state while removing raw1394. Looking at raw1394.c:cleanup_raw1394 - the order of doing things seemed incorrect to me after comparing other places in raw1394.c which do the same thing but with a different order. bash R running task