Re: [PATCH] rcu: change function declaration to bool

2015-05-11 Thread Nicholas Mc Guire
On Mon, 11 May 2015, Josh Triplett wrote: > On Mon, May 11, 2015 at 10:51:55AM +0200, Nicholas Mc Guire wrote: > > rcu_cpu_has_callbacks() is declared int but is actually returning bool and > > all call-sites currently use it as bool so the declaration should be bool > > as well. > > > >

Re: [PATCH] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 10:51:55AM +0200, Nicholas Mc Guire wrote: > rcu_cpu_has_callbacks() is declared int but is actually returning bool and > all call-sites currently use it as bool so the declaration should be bool > as well. > > Signed-off-by: Nicholas Mc Guire The patch seems reasonable

[PATCH] rcu: change function declaration to bool

2015-05-11 Thread Nicholas Mc Guire
rcu_cpu_has_callbacks() is declared int but is actually returning bool and all call-sites currently use it as bool so the declaration should be bool as well. Signed-off-by: Nicholas Mc Guire --- ./kernel/rcu/tree.c:3538 WARNING: return of wrong type int != bool, as the

[PATCH] rcu: change function declaration to bool

2015-05-11 Thread Nicholas Mc Guire
rcu_cpu_has_callbacks() is declared int but is actually returning bool and all call-sites currently use it as bool so the declaration should be bool as well. Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- ./kernel/rcu/tree.c:3538 WARNING: return of wrong type int !=

Re: [PATCH] rcu: change function declaration to bool

2015-05-11 Thread Nicholas Mc Guire
On Mon, 11 May 2015, Josh Triplett wrote: On Mon, May 11, 2015 at 10:51:55AM +0200, Nicholas Mc Guire wrote: rcu_cpu_has_callbacks() is declared int but is actually returning bool and all call-sites currently use it as bool so the declaration should be bool as well. Signed-off-by:

Re: [PATCH] rcu: change function declaration to bool

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 10:51:55AM +0200, Nicholas Mc Guire wrote: rcu_cpu_has_callbacks() is declared int but is actually returning bool and all call-sites currently use it as bool so the declaration should be bool as well. Signed-off-by: Nicholas Mc Guire hof...@osadl.org The patch seems