From: Arnd Bergmann
Date: Mon, 09 Mar 2015 13:06:52 +0100
> The rds_iw_add_conn function stores a large 'struct rds_sock' object
> on the stack in order to pass a pair of addresses.
As Sowmini pointed out, this function is not the top-level
guilty one, it's rds_iw_update_cm_id.
Please respin
On 03/09/2015 08:06 AM, Arnd Bergmann wrote:
The rds_iw_add_conn function stores a large 'struct rds_sock'
I think you might have a typo here- did you mean
rds_iw_update_cm_id above (which is the function that has
a 'struct rds_sock rs' on the stack)?
The rest of the change looks fine to me.
The rds_iw_add_conn function stores a large 'struct rds_sock'
object on the stack in order to pass a pair of addresses. This
happens to just fit withint the 1024 byte stack size warning
limit on x86, but just exceed that limit on ARM, which gives
us this warning:
net/rds/iw_rdma.c:200:1: warning:
The rds_iw_add_conn function stores a large 'struct rds_sock'
object on the stack in order to pass a pair of addresses. This
happens to just fit withint the 1024 byte stack size warning
limit on x86, but just exceed that limit on ARM, which gives
us this warning:
net/rds/iw_rdma.c:200:1: warning:
On 03/09/2015 08:06 AM, Arnd Bergmann wrote:
The rds_iw_add_conn function stores a large 'struct rds_sock'
I think you might have a typo here- did you mean
rds_iw_update_cm_id above (which is the function that has
a 'struct rds_sock rs' on the stack)?
The rest of the change looks fine to me.
From: Arnd Bergmann a...@arndb.de
Date: Mon, 09 Mar 2015 13:06:52 +0100
The rds_iw_add_conn function stores a large 'struct rds_sock' object
on the stack in order to pass a pair of addresses.
As Sowmini pointed out, this function is not the top-level
guilty one, it's rds_iw_update_cm_id.
6 matches
Mail list logo
