Re: [PATCH] reconnect_one(): fix a missing error code

2017-06-16 Thread J. Bruce Fields
On Fri, Jun 16, 2017 at 08:28:31AM +1000, NeilBrown wrote: > It wouldn't be too hard to create that scenario. It might be harder to > find a way to expose the corruption. Yes. Well, in any case, I assume this Al's to take. ACK to the patch, and it should go to stable as well. --b.

Re: [PATCH] reconnect_one(): fix a missing error code

2017-06-15 Thread NeilBrown
On Thu, Jun 15 2017, J. Bruce Fields wrote: > On Thu, Jun 15, 2017 at 07:54:57AM +1000, NeilBrown wrote: >> On Wed, Jun 14 2017, J. Bruce Fields wrote: >> >> > On Wed, Jun 14, 2017 at 12:30:02PM +0300, Dan Carpenter wrote: >> >> I found this bug by reviewing places where we do ERR_PTR(0) (which i

Re: [PATCH] reconnect_one(): fix a missing error code

2017-06-15 Thread J. Bruce Fields
On Thu, Jun 15, 2017 at 07:54:57AM +1000, NeilBrown wrote: > On Wed, Jun 14 2017, J. Bruce Fields wrote: > > > On Wed, Jun 14, 2017 at 12:30:02PM +0300, Dan Carpenter wrote: > >> I found this bug by reviewing places where we do ERR_PTR(0) (which is > >> NULL). > >> > >> We used to return an error

Re: [PATCH] reconnect_one(): fix a missing error code

2017-06-15 Thread Dan Carpenter
On Thu, Jun 15, 2017 at 07:54:57AM +1000, NeilBrown wrote: > On Wed, Jun 14 2017, J. Bruce Fields wrote: > > > On Wed, Jun 14, 2017 at 12:30:02PM +0300, Dan Carpenter wrote: > >> I found this bug by reviewing places where we do ERR_PTR(0) (which is > >> NULL). > >> > >> We used to return an error

Re: [PATCH] reconnect_one(): fix a missing error code

2017-06-14 Thread NeilBrown
On Wed, Jun 14 2017, J. Bruce Fields wrote: > On Wed, Jun 14, 2017 at 12:30:02PM +0300, Dan Carpenter wrote: >> I found this bug by reviewing places where we do ERR_PTR(0) (which is >> NULL). >> >> We used to return an error pointer if lookup_one_len() failed but we >> moved this code into a help

Re: [PATCH] reconnect_one(): fix a missing error code

2017-06-14 Thread J. Bruce Fields
On Wed, Jun 14, 2017 at 12:30:02PM +0300, Dan Carpenter wrote: > I found this bug by reviewing places where we do ERR_PTR(0) (which is > NULL). > > We used to return an error pointer if lookup_one_len() failed but we > moved this code into a helper function and accidentally removed that. > NULL is

[PATCH] reconnect_one(): fix a missing error code

2017-06-14 Thread Dan Carpenter
I found this bug by reviewing places where we do ERR_PTR(0) (which is NULL). We used to return an error pointer if lookup_one_len() failed but we moved this code into a helper function and accidentally removed that. NULL is a valid return for this function but it's not what we intended. Fixes: bb