Re: [PATCH] regmap: Disable debugfs when locking is disabled

2017-12-13 Thread Bartosz Golaszewski
2017-12-13 17:47 GMT+01:00 Mark Brown : > On Wed, Dec 13, 2017 at 04:50:20PM +0100, Bartosz Golaszewski wrote: > >> I would still add the dev_dbg() here like in my version, since someone >> may start wondering why the debugfs files are not being creating for >> certain regmaps. > > Sure, can you se

Re: [PATCH] regmap: Disable debugfs when locking is disabled

2017-12-13 Thread Mark Brown
On Wed, Dec 13, 2017 at 04:50:20PM +0100, Bartosz Golaszewski wrote: > I would still add the dev_dbg() here like in my version, since someone > may start wondering why the debugfs files are not being creating for > certain regmaps. Sure, can you send a patch for that please - I already applied mi

Re: [PATCH] regmap: Disable debugfs when locking is disabled

2017-12-13 Thread Bartosz Golaszewski
2017-12-12 18:13 GMT+01:00 Mark Brown : > The recently added support for disabling the regmap internal locking left > debugfs enabled for devices with the locking disabled. This is a problem > since debugfs allows userspace to do things like initiate reads from the > hardware which will use the scr

[PATCH] regmap: Disable debugfs when locking is disabled

2017-12-12 Thread Mark Brown
The recently added support for disabling the regmap internal locking left debugfs enabled for devices with the locking disabled. This is a problem since debugfs allows userspace to do things like initiate reads from the hardware which will use the scratch buffers protected by the regmap locking so