Re: [PATCH] regmap: Ensure regmap_register_patch() is compatible with fast_io

2014-03-18 Thread Mark Brown
On Tue, Mar 18, 2014 at 02:43:18PM +0100, Levente Kurusa wrote: > 2014-03-18 13:02 GMT+01:00 Mark Brown : > > + if (p) { > > + memcpy(p + map->patch_regs, regs, num_regs * sizeof(*regs)); > > + map->patch = p; > > + map->patch_regs += num_regs; > > +

Re: [PATCH] regmap: Ensure regmap_register_patch() is compatible with fast_io

2014-03-18 Thread Levente Kurusa
Hi Mark, Just a single, mini-comment. 2014-03-18 13:02 GMT+01:00 Mark Brown : > From: Mark Brown > > With fast_io we use mutexes to lock the I/O operations so we would need > to do GFP_ATOMIC allocations if we wanted to do allocations inside the > lock as we do currently. Since it is unlikely t

[PATCH] regmap: Ensure regmap_register_patch() is compatible with fast_io

2014-03-18 Thread Mark Brown
From: Mark Brown With fast_io we use mutexes to lock the I/O operations so we would need to do GFP_ATOMIC allocations if we wanted to do allocations inside the lock as we do currently. Since it is unlikely that we will want to register a patch outside of init where concurrency shouldn't be an iss