Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Mark Brown
On Wed, Jul 16, 2014 at 08:12:04PM +0530, pramod gurav wrote: > On Wed, Jul 16, 2014 at 7:48 PM, Mark Brown wrote: > > A dependency from a selected symbol will have no effect. > Thanks Mark. So essentially in this case PMIC driver should 'select SPMI'. > Right? I would expect it to depend on SP

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread pramod gurav
On Wed, Jul 16, 2014 at 7:48 PM, Mark Brown wrote: > On Wed, Jul 16, 2014 at 05:00:54PM +0300, Ivan T. Ivanov wrote: >> On Wed, 2014-07-16 at 14:53 +0100, Mark Brown wrote: > >> > No, this isn't an either/or thing - the dependency is absolutely >> > mandatory if the device needs SPMI. The defconf

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Mark Brown
On Wed, Jul 16, 2014 at 05:00:54PM +0300, Ivan T. Ivanov wrote: > On Wed, 2014-07-16 at 14:53 +0100, Mark Brown wrote: > > No, this isn't an either/or thing - the dependency is absolutely > > mandatory if the device needs SPMI. The defconfigs are a separate > > thing, they just exist to give peop

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Ivan T. Ivanov
On Wed, 2014-07-16 at 14:53 +0100, Mark Brown wrote: > On Wed, Jul 16, 2014 at 06:26:15PM +0530, Pramod Gurav wrote: > > Fix your mailer to word wrap within paragraphs, this will make your > mails more legible - see Documentation/email-clients.txt. > > > On Wednesday, 16 July, 2014 5:55pm, "Stani

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Mark Brown
On Wed, Jul 16, 2014 at 06:26:15PM +0530, Pramod Gurav wrote: Fix your mailer to word wrap within paragraphs, this will make your mails more legible - see Documentation/email-clients.txt. > On Wednesday, 16 July, 2014 5:55pm, "Stanimir Varbanov" > said: > The CONFIG_SPMI option is visible in m

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Stanimir Varbanov
> > Thanks. > I misunderstood the Kconfig documentation which says, "Reverse dependencies > can only be used with boolean or tristate symbols". In the note following > this statement doc says, "In general use select only for non-visible symbols". > > The CONFIG_SPMI option is visible in menuc

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Pramod Gurav
Hi, On Wednesday, 16 July, 2014 5:55pm, "Stanimir Varbanov" said: > > config REGMAP_SPMI + select SPMI >>> >>> NO, IMO the CONFIG_SPMI should be enabled by qcom_defconfig and >>> multi_v7_defconfig. See CONFIG_I2C and REGMAP_I2C for example. >>> >> >> I am using multi_v7_defc

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Stanimir Varbanov
>>> >>> config REGMAP_SPMI >>> + select SPMI >> >> NO, IMO the CONFIG_SPMI should be enabled by qcom_defconfig and >> multi_v7_defconfig. See CONFIG_I2C and REGMAP_I2C for example. >> > > I am using multi_v7_defconfig but its not enabling it. I ran qcom_defconfig > which does. yes, it seems

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Lars-Peter Clausen
On 07/16/2014 01:39 PM, pramod.gurav@gmail.com wrote: From: Pramod Gurav REGMAP_SPMI module calls some functions from SPMI hence build breaks when SPMI is not enabled while compiling REGMAP_SPMI with below linker errors: drivers/built-in.o: In function `regmap_spmi_ext_read': :(.text+0x114

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Pramod Gurav
Hi, On Wednesday, 16 July, 2014 5:37pm, "Stanimir Varbanov" said: > Hi, > > >> >> Signed-off-by: Pramod Gurav >> CC: Josh Cartwright >> CC: Mark Brown >> --- >> This was found when I enabled support for Qualcomm QPNP PMICs and was >> compiling it. It selects REGMAP_SPMI and hence the crash

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Stanimir Varbanov
Hi, > > Signed-off-by: Pramod Gurav > CC: Josh Cartwright > CC: Mark Brown > --- > This was found when I enabled support for Qualcomm QPNP PMICs and was > compiling it. It selects REGMAP_SPMI and hence the crash. > > drivers/base/regmap/Kconfig |1 + > 1 file changed, 1 insertion(+) >

[PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread pramod . gurav . etc
From: Pramod Gurav REGMAP_SPMI module calls some functions from SPMI hence build breaks when SPMI is not enabled while compiling REGMAP_SPMI with below linker errors: drivers/built-in.o: In function `regmap_spmi_ext_read': :(.text+0x1143ec): undefined reference to `spmi_ext_register_read' :(.tex