Re: [PATCH] regmap: Remove __attribute__ ((packed))

2013-03-15 Thread Dimitris Papastamos
On Fri, Mar 15, 2013 at 04:53:51PM +, Mark Brown wrote: > On Fri, Mar 15, 2013 at 11:16:02AM +, Dimitris Papastamos wrote: > > > On my system there was no benefit of using it, it just happens > > that the struct is aligned properly and needs no padding. > > OK, so which system was that

Re: [PATCH] regmap: Remove __attribute__ ((packed))

2013-03-15 Thread Mark Brown
On Fri, Mar 15, 2013 at 11:16:02AM +, Dimitris Papastamos wrote: > On my system there was no benefit of using it, it just happens > that the struct is aligned properly and needs no padding. OK, so which system was that and is it not possible that other systems will get something useful from

Re: [PATCH] regmap: Remove __attribute__ ((packed))

2013-03-15 Thread Dimitris Papastamos
On Fri, Mar 15, 2013 at 01:36:40AM +, Mark Brown wrote: > On Thu, Mar 14, 2013 at 03:26:19PM +, Dimitris Papastamos wrote: > > There is no point having this. The space gains are trivial if there > > are any at all. > > Applied, but numbers would have been nice and... > > > Change-Id:

Re: [PATCH] regmap: Remove __attribute__ ((packed))

2013-03-15 Thread Dimitris Papastamos
On Fri, Mar 15, 2013 at 01:36:40AM +, Mark Brown wrote: On Thu, Mar 14, 2013 at 03:26:19PM +, Dimitris Papastamos wrote: There is no point having this. The space gains are trivial if there are any at all. Applied, but numbers would have been nice and... Change-Id:

Re: [PATCH] regmap: Remove __attribute__ ((packed))

2013-03-15 Thread Mark Brown
On Fri, Mar 15, 2013 at 11:16:02AM +, Dimitris Papastamos wrote: On my system there was no benefit of using it, it just happens that the struct is aligned properly and needs no padding. OK, so which system was that and is it not possible that other systems will get something useful from

Re: [PATCH] regmap: Remove __attribute__ ((packed))

2013-03-15 Thread Dimitris Papastamos
On Fri, Mar 15, 2013 at 04:53:51PM +, Mark Brown wrote: On Fri, Mar 15, 2013 at 11:16:02AM +, Dimitris Papastamos wrote: On my system there was no benefit of using it, it just happens that the struct is aligned properly and needs no padding. OK, so which system was that and is it

Re: [PATCH] regmap: Remove __attribute__ ((packed))

2013-03-14 Thread Mark Brown
On Thu, Mar 14, 2013 at 03:26:19PM +, Dimitris Papastamos wrote: > There is no point having this. The space gains are trivial if there > are any at all. Applied, but numbers would have been nice and... > Change-Id: Ib4b1320420f780dcf5b9a1e4b05f5805691c4d9f ...this shouldn't be in upstream

[PATCH] regmap: Remove __attribute__ ((packed))

2013-03-14 Thread Dimitris Papastamos
There is no point having this. The space gains are trivial if there are any at all. Change-Id: Ib4b1320420f780dcf5b9a1e4b05f5805691c4d9f Signed-off-by: Dimitris Papastamos --- drivers/base/regmap/regcache-rbtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] regmap: Remove __attribute__ ((packed))

2013-03-14 Thread Dimitris Papastamos
There is no point having this. The space gains are trivial if there are any at all. Change-Id: Ib4b1320420f780dcf5b9a1e4b05f5805691c4d9f Signed-off-by: Dimitris Papastamos d...@opensource.wolfsonmicro.com --- drivers/base/regmap/regcache-rbtree.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] regmap: Remove __attribute__ ((packed))

2013-03-14 Thread Mark Brown
On Thu, Mar 14, 2013 at 03:26:19PM +, Dimitris Papastamos wrote: There is no point having this. The space gains are trivial if there are any at all. Applied, but numbers would have been nice and... Change-Id: Ib4b1320420f780dcf5b9a1e4b05f5805691c4d9f ...this shouldn't be in upstream