Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events

2015-03-19 Thread Mark Brown
On Thu, Mar 19, 2015 at 03:52:28PM -0400, Steven Rostedt wrote: > I'm not sure what you mean be driver-level vs subsystem-level. How is > this a subsystem level as regmap happens to be in the drivers code. Lots of generic, subsystem level code lives in drivers/ - most directories in there have a

Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events

2015-03-19 Thread Steven Rostedt
/me decides to continue the "reply backwards" method. On Mon, 09 Mar 2015 10:48:22 +0100 Philipp Zabel wrote: > Am Samstag, den 07.03.2015, 10:57 + schrieb Mark Brown: > > On Fri, Mar 06, 2015 at 03:16:55PM +0100, Philipp Zabel wrote: > > > > > #include > > > -#include > > > > > > #i

Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events

2015-03-19 Thread Steven Rostedt
On Mon, 9 Mar 2015 10:42:40 + Mark Brown wrote: > On Mon, Mar 09, 2015 at 10:48:22AM +0100, Philipp Zabel wrote: > > > Good point. As I see it I have three possiblities now: > > > a) Just #include "../../../drivers/base/regmap/internal.h" in > >include/trace/events/regmap.h > > I think

Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events

2015-03-09 Thread Mark Brown
On Mon, Mar 09, 2015 at 10:48:22AM +0100, Philipp Zabel wrote: > Good point. As I see it I have three possiblities now: > a) Just #include "../../../drivers/base/regmap/internal.h" in >include/trace/events/regmap.h I think this is my preference - it looks ugly which means that it's not likel

Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events

2015-03-09 Thread Philipp Zabel
Am Samstag, den 07.03.2015, 10:57 + schrieb Mark Brown: > On Fri, Mar 06, 2015 at 03:16:55PM +0100, Philipp Zabel wrote: > > > #include > > -#include > > > > #include "internal.h" > > > > +#include > > + > > The change is basically OK but the above is a bit too funky for my > taste -

Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events

2015-03-07 Thread Mark Brown
On Fri, Mar 06, 2015 at 03:16:55PM +0100, Philipp Zabel wrote: > #include > -#include > > #include "internal.h" > > +#include > + The change is basically OK but the above is a bit too funky for my taste - it feels like it's asking for annoying compile breakage if anyone changes anything.

[PATCH] regmap: introduce regmap_name to fix syscon regmap trace events

2015-03-06 Thread Philipp Zabel
This patch fixes a NULL pointer dereference when enabling regmap event tracing in the presence of a syscon regmap, introduced by commit bdb0066df96e ("mfd: syscon: Decouple syscon interface from platform devices"). That patch introduced syscon regmaps that have their dev field set to NULL. The regm