Re: [PATCH] regulator: core: Fix s2idle

Hi Mark, On Tue, Jan 30, 2018 at 1:03 PM, Mark Brown wrote: > On Tue, Jan 30, 2018 at 11:32:26AM +0100, Geert Uytterhoeven wrote: >> But I have no idea what impact it has. So far it doesn't seem to hurt, >> though. > > I suspect that instead what we should be doing is changing the > set_suspend_

Re: [PATCH] regulator: core: Fix s2idle

On Tue, Jan 30, 2018 at 11:32:26AM +0100, Geert Uytterhoeven wrote: > But I have no idea what impact it has. So far it doesn't seem to hurt, > though. I suspect that instead what we should be doing is changing the set_suspend_state() check to the below - if we don't have any constraints or there

[PATCH] regulator: core: Fix s2idle

Systems using regulators can no longer be frozen: $ echo 0 > /sys/module/printk/parameters/console_suspend $ echo freeze > /sys/power/state PM: suspend entry (s2idle) PM: Syncing filesystems ... done. Freezing user space processes ... (elapsed 0.011 seconds) done. OOM killer disab