Re: [PATCH] regulator: fixed: Default enable high on DT regulators

2018-10-04 Thread Mark Brown
On Wed, Oct 03, 2018 at 06:08:09PM +, Leonard Crestez wrote: > On Wed, 2018-10-03 at 13:10 +0100, Mark Brown wrote: > > No, that's definitely not desired. We don't want to change the state of > > the regulator at all if we can avoid it unless the user explicitly asked > > for it. > That also

Re: [PATCH] regulator: fixed: Default enable high on DT regulators

2018-10-04 Thread Linus Walleij
On Wed, Oct 3, 2018 at 8:08 PM Leonard Crestez wrote: > On Wed, 2018-10-03 at 13:10 +0100, Mark Brown wrote: > > On Tue, Oct 02, 2018 at 01:42:38PM +, Leonard Crestez wrote: > > > > > This turns the phy off and on again instead of leaving it up from uboot > > > and it doesn't work for some rea

Re: [PATCH] regulator: fixed: Default enable high on DT regulators

2018-10-03 Thread Leonard Crestez
On Wed, 2018-10-03 at 13:10 +0100, Mark Brown wrote: > On Tue, Oct 02, 2018 at 01:42:38PM +, Leonard Crestez wrote: > > > This turns the phy off and on again instead of leaving it up from uboot > > and it doesn't work for some reason. However looking at > > reg_fixed_voltage_probe introducing

Re: [PATCH] regulator: fixed: Default enable high on DT regulators

2018-10-03 Thread Mark Brown
On Tue, Oct 02, 2018 at 01:42:38PM +, Leonard Crestez wrote: > This turns the phy off and on again instead of leaving it up from uboot > and it doesn't work for some reason. However looking at > reg_fixed_voltage_probe introducing an edge seems to be intentional for > regulators which are not

Re: [PATCH] regulator: fixed: Default enable high on DT regulators

2018-10-02 Thread Leonard Crestez
On Mon, 2018-10-01 at 22:43 +0200, Linus Walleij wrote: > commit efdfeb079cc3 > ("regulator: fixed: Convert to use GPIO descriptor only") > switched to use gpiod_get() to look up the regulator from the > gpiolib core whether that is device tree or boardfile. > > This meant that we activate the cod

Re: [PATCH] regulator: fixed: Default enable high on DT regulators

2018-10-01 Thread John Stultz
On Mon, Oct 1, 2018 at 1:43 PM, Linus Walleij wrote: > commit efdfeb079cc3 > ("regulator: fixed: Convert to use GPIO descriptor only") > switched to use gpiod_get() to look up the regulator from the > gpiolib core whether that is device tree or boardfile. > > This meant that we activate the code i

[PATCH] regulator: fixed: Default enable high on DT regulators

2018-10-01 Thread Linus Walleij
commit efdfeb079cc3 ("regulator: fixed: Convert to use GPIO descriptor only") switched to use gpiod_get() to look up the regulator from the gpiolib core whether that is device tree or boardfile. This meant that we activate the code in a603a2b8d86e ("gpio: of: Add special quirk to parse regulator f