Re: [PATCH] regulator: fixed: Use more standard GPIO binding

2018-10-07 Thread Linus Walleij
On Fri, Oct 5, 2018 at 10:17 PM Rob Herring wrote: > BTW, 'enable-active-high' is also a bit strange as that should just be > encoded into 'enable-gpio' flags. We should really deprecate that. I have been struggling with this (and similar flags in other subsystems) and the current plan is to

Re: [PATCH] regulator: fixed: Use more standard GPIO binding

2018-10-07 Thread Linus Walleij
On Fri, Oct 5, 2018 at 10:17 PM Rob Herring wrote: > BTW, 'enable-active-high' is also a bit strange as that should just be > encoded into 'enable-gpio' flags. We should really deprecate that. I have been struggling with this (and similar flags in other subsystems) and the current plan is to

Re: [PATCH] regulator: fixed: Use more standard GPIO binding

2018-10-05 Thread Rob Herring
On Thu, Oct 4, 2018 at 8:54 AM Mark Brown wrote: > > On Thu, Oct 04, 2018 at 01:32:13PM +0200, Linus Walleij wrote: > > On Thu, Oct 4, 2018 at 12:50 PM Mark Brown wrote: > > > On Thu, Oct 04, 2018 at 11:06:54AM +0200, Linus Walleij wrote: > > > > > Optional properties: > > > > -- gpio: gpio to

Re: [PATCH] regulator: fixed: Use more standard GPIO binding

2018-10-05 Thread Rob Herring
On Thu, Oct 4, 2018 at 8:54 AM Mark Brown wrote: > > On Thu, Oct 04, 2018 at 01:32:13PM +0200, Linus Walleij wrote: > > On Thu, Oct 4, 2018 at 12:50 PM Mark Brown wrote: > > > On Thu, Oct 04, 2018 at 11:06:54AM +0200, Linus Walleij wrote: > > > > > Optional properties: > > > > -- gpio: gpio to

Re: [PATCH] regulator: fixed: Use more standard GPIO binding

2018-10-04 Thread Mark Brown
On Thu, Oct 04, 2018 at 01:32:13PM +0200, Linus Walleij wrote: > On Thu, Oct 4, 2018 at 12:50 PM Mark Brown wrote: > > On Thu, Oct 04, 2018 at 11:06:54AM +0200, Linus Walleij wrote: > > > Optional properties: > > > -- gpio: gpio to use for enable control > > > +- gpios: gpio to use for enable

Re: [PATCH] regulator: fixed: Use more standard GPIO binding

2018-10-04 Thread Mark Brown
On Thu, Oct 04, 2018 at 01:32:13PM +0200, Linus Walleij wrote: > On Thu, Oct 4, 2018 at 12:50 PM Mark Brown wrote: > > On Thu, Oct 04, 2018 at 11:06:54AM +0200, Linus Walleij wrote: > > > Optional properties: > > > -- gpio: gpio to use for enable control > > > +- gpios: gpio to use for enable

Re: [PATCH] regulator: fixed: Use more standard GPIO binding

2018-10-04 Thread Linus Walleij
On Thu, Oct 4, 2018 at 12:50 PM Mark Brown wrote: > On Thu, Oct 04, 2018 at 11:06:54AM +0200, Linus Walleij wrote: > > > Optional properties: > > -- gpio: gpio to use for enable control > > +- gpios: gpio to use for enable control > > Are we supposed to be able to have just plain gpios as a

Re: [PATCH] regulator: fixed: Use more standard GPIO binding

2018-10-04 Thread Linus Walleij
On Thu, Oct 4, 2018 at 12:50 PM Mark Brown wrote: > On Thu, Oct 04, 2018 at 11:06:54AM +0200, Linus Walleij wrote: > > > Optional properties: > > -- gpio: gpio to use for enable control > > +- gpios: gpio to use for enable control > > Are we supposed to be able to have just plain gpios as a

Re: [PATCH] regulator: fixed: Use more standard GPIO binding

2018-10-04 Thread Mark Brown
On Thu, Oct 04, 2018 at 11:06:54AM +0200, Linus Walleij wrote: > Optional properties: > -- gpio: gpio to use for enable control > +- gpios: gpio to use for enable control Are we supposed to be able to have just plain gpios as a standards conforming property or would best practice be to call it

Re: [PATCH] regulator: fixed: Use more standard GPIO binding

2018-10-04 Thread Mark Brown
On Thu, Oct 04, 2018 at 11:06:54AM +0200, Linus Walleij wrote: > Optional properties: > -- gpio: gpio to use for enable control > +- gpios: gpio to use for enable control Are we supposed to be able to have just plain gpios as a standards conforming property or would best practice be to call it

[PATCH] regulator: fixed: Use more standard GPIO binding

2018-10-04 Thread Linus Walleij
The fixed regulator uses "gpio" (singularis) for the GPIO line but the standard GPIO bindings recommend "gpios" (pluralis). We have augmented the Linux kernel to handle both, so recommend the best practice and deprecate the singularis variant. Cc: devicet...@vger.kernel.org Cc: Leonard Crestez

[PATCH] regulator: fixed: Use more standard GPIO binding

2018-10-04 Thread Linus Walleij
The fixed regulator uses "gpio" (singularis) for the GPIO line but the standard GPIO bindings recommend "gpios" (pluralis). We have augmented the Linux kernel to handle both, so recommend the best practice and deprecate the singularis variant. Cc: devicet...@vger.kernel.org Cc: Leonard Crestez