Re: [PATCH] remove duplicate checking code

2014-05-30 Thread Joerg Roedel
On Thu, May 29, 2014 at 03:45:47PM +0200, Paul Bolle wrote: > On Mon, 2014-05-26 at 11:39 +0200, Joerg Roedel wrote: > > On Fri, May 16, 2014 at 03:39:40PM +0800, Vaughan Cao wrote: > > > amd_iommu_rlookup_table[devid] != NULL is already guaranteed by > > > check_device > > > called before, it's

Re: [PATCH] remove duplicate checking code

2014-05-30 Thread Joerg Roedel
On Thu, May 29, 2014 at 03:45:47PM +0200, Paul Bolle wrote: On Mon, 2014-05-26 at 11:39 +0200, Joerg Roedel wrote: On Fri, May 16, 2014 at 03:39:40PM +0800, Vaughan Cao wrote: amd_iommu_rlookup_table[devid] != NULL is already guaranteed by check_device called before, it's fine to

Re: [PATCH] remove duplicate checking code

2014-05-29 Thread Paul Bolle
On Mon, 2014-05-26 at 11:39 +0200, Joerg Roedel wrote: > On Fri, May 16, 2014 at 03:39:40PM +0800, Vaughan Cao wrote: > > amd_iommu_rlookup_table[devid] != NULL is already guaranteed by check_device > > called before, it's fine to attach device at this point. > > > > Signed-off-by: Vaughan Cao >

Re: [PATCH] remove duplicate checking code

2014-05-29 Thread Paul Bolle
On Mon, 2014-05-26 at 11:39 +0200, Joerg Roedel wrote: On Fri, May 16, 2014 at 03:39:40PM +0800, Vaughan Cao wrote: amd_iommu_rlookup_table[devid] != NULL is already guaranteed by check_device called before, it's fine to attach device at this point. Signed-off-by: Vaughan Cao

Re: [PATCH] remove duplicate checking code

2014-05-26 Thread Joerg Roedel
On Fri, May 16, 2014 at 03:39:40PM +0800, Vaughan Cao wrote: > amd_iommu_rlookup_table[devid] != NULL is already guaranteed by check_device > called before, it's fine to attach device at this point. > > Signed-off-by: Vaughan Cao > --- > drivers/iommu/amd_iommu.c | 6 -- > 1 file changed, 6

Re: [PATCH] remove duplicate checking code

2014-05-26 Thread Joerg Roedel
On Fri, May 16, 2014 at 03:39:40PM +0800, Vaughan Cao wrote: amd_iommu_rlookup_table[devid] != NULL is already guaranteed by check_device called before, it's fine to attach device at this point. Signed-off-by: Vaughan Cao vaughan@oracle.com --- drivers/iommu/amd_iommu.c | 6 -- 1

[PATCH] remove duplicate checking code

2014-05-16 Thread Vaughan Cao
amd_iommu_rlookup_table[devid] != NULL is already guaranteed by check_device called before, it's fine to attach device at this point. Signed-off-by: Vaughan Cao --- drivers/iommu/amd_iommu.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/iommu/amd_iommu.c

[PATCH] remove duplicate checking code

2014-05-16 Thread Vaughan Cao
amd_iommu_rlookup_table[devid] != NULL is already guaranteed by check_device called before, it's fine to attach device at this point. Signed-off-by: Vaughan Cao vaughan@oracle.com --- drivers/iommu/amd_iommu.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/iommu/amd_iommu.c