Re: [PATCH] remove untouched code in kfifo_in

2012-10-23 Thread Andrew Morton
On Tue, 23 Oct 2012 21:25:46 +0200 richard -rw- weinberger wrote: > > Subject: [PATCH] Replace the type check code with typecheck() in kfifo_in > > > > In kfifo_in marco, one piece of code which is arounded by if(0) will check > > the > > type of __tmp->ptr_const and __buf. If they are different

Re: [PATCH] remove untouched code in kfifo_in

2012-10-23 Thread richard -rw- weinberger
On Tue, Oct 23, 2012 at 4:27 AM, Richard Yang wrote: > On Mon, Oct 22, 2012 at 04:56:02PM -0700, Andrew Morton wrote: >>On Fri, 19 Oct 2012 09:34:43 +0200 (CEST) >>Jiri Kosina wrote: >> >>> On Fri, 19 Oct 2012, Stefani Seibold wrote: >>> >>> > > > In kfifo_in marco, one piece of code is arounded

Re: [PATCH] remove untouched code in kfifo_in

2012-10-22 Thread Andrew Morton
On Fri, 19 Oct 2012 09:34:43 +0200 (CEST) Jiri Kosina wrote: > On Fri, 19 Oct 2012, Stefani Seibold wrote: > > > > > In kfifo_in marco, one piece of code is arounded by if(0). This code in > > > > introduced by Stefani Seibold to suppress a > > > > compiler > > > > warning. This warning is not

Re: [PATCH] remove untouched code in kfifo_in

2012-10-19 Thread richard -rw- weinberger
On Fri, Oct 19, 2012 at 8:18 AM, Richard Yang wrote: > On Fri, Oct 19, 2012 at 07:23:09AM +0200, Stefani Seibold wrote: >> >>Am Freitag, den 19.10.2012, 00:37 +0200 schrieb richard -rw- weinberger: >>> On Thu, Oct 18, 2012 at 3:59 PM, Wei Yang >>> wrote: >>> > In kfifo_in marco, one piece of cod

Re: [PATCH] remove untouched code in kfifo_in

2012-10-19 Thread Jiri Kosina
On Fri, 19 Oct 2012, Stefani Seibold wrote: > > > In kfifo_in marco, one piece of code is arounded by if(0). This code in > > > introduced by Stefani Seibold to suppress a compiler > > > warning. This warning is not there with the upgrade of gcc version. > > > > > > This patch just remove this co

Re: [PATCH] remove untouched code in kfifo_in

2012-10-18 Thread Stefani Seibold
Am Freitag, den 19.10.2012, 00:37 +0200 schrieb richard -rw- weinberger: > On Thu, Oct 18, 2012 at 3:59 PM, Wei Yang wrote: > > In kfifo_in marco, one piece of code is arounded by if(0). This code in > > introduced by Stefani Seibold to suppress a compiler > > warning. This warning is not there

Re: [PATCH] remove untouched code in kfifo_in

2012-10-18 Thread richard -rw- weinberger
On Thu, Oct 18, 2012 at 3:59 PM, Wei Yang wrote: > In kfifo_in marco, one piece of code is arounded by if(0). This code in > introduced by Stefani Seibold to suppress a compiler > warning. This warning is not there with the upgrade of gcc version. > > This patch just remove this code. Are you su

[PATCH] remove untouched code in kfifo_in

2012-10-18 Thread Wei Yang
In kfifo_in marco, one piece of code is arounded by if(0). This code in introduced by Stefani Seibold to suppress a compiler warning. This warning is not there with the upgrade of gcc version. This patch just remove this code. --- include/linux/kfifo.h |4 1 files changed, 0 insertions

Re: [PATCH] remove untouched code in kfifo_in

2012-10-18 Thread Jiri Kosina
On Thu, 18 Oct 2012, Stefani Seibold wrote: > > >This was introduce by me to suppress a compiler warning, so don't remove > > >it. > > Which warning? I compile by removing this, but not find warning. > > I compile it on x86_64 platform. > > > > > Sorry, i can't remember, it is three years and tw

Re: [PATCH] remove untouched code in kfifo_in

2012-10-17 Thread Stefani Seibold
Am Donnerstag, den 18.10.2012, 09:59 +0800 schrieb Richard Yang: > On Wed, Oct 17, 2012 at 09:51:49PM +0200, Stefani Seibold wrote: > >This was introduce by me to suppress a compiler warning, so don't remove > >it. > Which warning? I compile by removing this, but not find warning. > I compile it o

Re: [PATCH] remove untouched code in kfifo_in

2012-10-17 Thread Stefani Seibold
This was introduce by me to suppress a compiler warning, so don't remove it. Am Mittwoch, den 17.10.2012, 16:05 +0200 schrieb Jiri Kosina: > On Wed, 17 Oct 2012, Richard Yang wrote: > > > >> This patch just remove this code. > > >> --- > > >> include/linux/kfifo.h |4 > > >> 1 files ch

Re: [PATCH] remove untouched code in kfifo_in

2012-10-17 Thread Jiri Kosina
On Wed, 17 Oct 2012, Richard Yang wrote: > >> This patch just remove this code. > >> --- > >> include/linux/kfifo.h |4 > >> 1 files changed, 0 insertions(+), 4 deletions(-) > >> > >> diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h > >> index 10308c6..e7015bb 100644 > >> ---

Re: [PATCH] remove untouched code in kfifo_in

2012-10-17 Thread Jiri Kosina
On Wed, 17 Oct 2012, Wei Yang wrote: > In kfifo_in marco, one piece of code is arounded by if(0). > > This patch just remove this code. > --- > include/linux/kfifo.h |4 > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h >