Re: [PATCH] remove warning about e1000_suspend

2005-08-08 Thread Martin J. Bligh
--Michael Ellerman <[EMAIL PROTECTED]> wrote (on Monday, August 08, 2005 18:49:34 +1000): > On Mon, 8 Aug 2005 16:09, Nikhil Dharashivkar wrote: >> Hi Martin, >> But e1000_notify_reboot () function calls this e1000_suspend() >> function irrespective of CONFIG_FM is defined or not. So

Re: [PATCH] remove warning about e1000_suspend

2005-08-08 Thread Michael Ellerman
On Mon, 8 Aug 2005 16:09, Nikhil Dharashivkar wrote: > Hi Martin, > But e1000_notify_reboot () function calls this e1000_suspend() > function irrespective of CONFIG_FM is defined or not. So according to > your soution, what if CONFIG_FM is not defined. Does it? I can't find it. Martin's

Re: [PATCH] remove warning about e1000_suspend

2005-08-08 Thread Martin J. Bligh
--Nikhil Dharashivkar <[EMAIL PROTECTED]> wrote (on Monday, August 08, 2005 11:39:07 +0530): > Hi Martin, > But e1000_notify_reboot () function calls this e1000_suspend() > function irrespective of CONFIG_FM is defined or not. So according to > your soution, what if CONFIG_FM is not

Re: [PATCH] remove warning about e1000_suspend

2005-08-08 Thread Nikhil Dharashivkar
Hi Martin, But e1000_notify_reboot () function calls this e1000_suspend() function irrespective of CONFIG_FM is defined or not. So according to your soution, what if CONFIG_FM is not defined. On 8/8/05, Martin J. Bligh <[EMAIL PROTECTED]> wrote: > e1000_suspend is only used under #ifdef

Re: [PATCH] remove warning about e1000_suspend

2005-08-08 Thread Nikhil Dharashivkar
Hi Martin, But e1000_notify_reboot () function calls this e1000_suspend() function irrespective of CONFIG_FM is defined or not. So according to your soution, what if CONFIG_FM is not defined. On 8/8/05, Martin J. Bligh [EMAIL PROTECTED] wrote: e1000_suspend is only used under #ifdef

Re: [PATCH] remove warning about e1000_suspend

2005-08-08 Thread Martin J. Bligh
--Nikhil Dharashivkar [EMAIL PROTECTED] wrote (on Monday, August 08, 2005 11:39:07 +0530): Hi Martin, But e1000_notify_reboot () function calls this e1000_suspend() function irrespective of CONFIG_FM is defined or not. So according to your soution, what if CONFIG_FM is not defined.

Re: [PATCH] remove warning about e1000_suspend

2005-08-08 Thread Michael Ellerman
On Mon, 8 Aug 2005 16:09, Nikhil Dharashivkar wrote: Hi Martin, But e1000_notify_reboot () function calls this e1000_suspend() function irrespective of CONFIG_FM is defined or not. So according to your soution, what if CONFIG_FM is not defined. Does it? I can't find it. Martin's patch

Re: [PATCH] remove warning about e1000_suspend

2005-08-08 Thread Martin J. Bligh
--Michael Ellerman [EMAIL PROTECTED] wrote (on Monday, August 08, 2005 18:49:34 +1000): On Mon, 8 Aug 2005 16:09, Nikhil Dharashivkar wrote: Hi Martin, But e1000_notify_reboot () function calls this e1000_suspend() function irrespective of CONFIG_FM is defined or not. So according to

[PATCH] remove warning about e1000_suspend

2005-08-07 Thread Martin J. Bligh
e1000_suspend is only used under #ifdef CONFIG_PM. Move the declaration of it to be the same way, just like e1000_resume, otherwise gcc whines on compile. I offer as evidence: static struct pci_driver e1000_driver = { .name = e1000_driver_name, .id_table

[PATCH] remove warning about e1000_suspend

2005-08-07 Thread Martin J. Bligh
e1000_suspend is only used under #ifdef CONFIG_PM. Move the declaration of it to be the same way, just like e1000_resume, otherwise gcc whines on compile. I offer as evidence: static struct pci_driver e1000_driver = { .name = e1000_driver_name, .id_table