Re: [PATCH] resource: make sure requested range intersects root range

2012-07-12 Thread Purdila, Octavian
Adding back people on CC, I accidentally reply-to instead of reply-to-all. On Thu, Jul 12, 2012 at 7:30 PM, Ram Pai wrote: > On Thu, Jul 12, 2012 at 12:56:08PM +0300, Purdila, Octavian wrote: >> On Thu, Jul 12, 2012 at 11:56 AM, Ram Pai wrote: > > ..snip.. >> > Offcourse; it does not warn when t

Re: [PATCH] resource: make sure requested range intersects root range

2012-07-12 Thread Ram Pai
On Thu, Jul 12, 2012 at 10:02:06AM +0800, Ram Pai wrote: > On Wed, Jul 11, 2012 at 06:26:49PM +0300, Purdila, Octavian wrote: > > On Wed, Jul 11, 2012 at 5:54 PM, Ram Pai wrote: > > > On Wed, Jul 11, 2012 at 02:06:10PM +0300, Purdila, Octavian wrote: > > >> On Wed, Jul 11, 2012 at 5:09 AM, Ram Pai

Re: [PATCH] resource: make sure requested range intersects root range

2012-07-11 Thread Ram Pai
On Wed, Jul 11, 2012 at 06:26:49PM +0300, Purdila, Octavian wrote: > On Wed, Jul 11, 2012 at 5:54 PM, Ram Pai wrote: > > On Wed, Jul 11, 2012 at 02:06:10PM +0300, Purdila, Octavian wrote: > >> On Wed, Jul 11, 2012 at 5:09 AM, Ram Pai wrote: > >> > >> > > >> > Wait.. I am not sure this will fix th

Re: [PATCH] resource: make sure requested range intersects root range

2012-07-11 Thread Purdila, Octavian
On Wed, Jul 11, 2012 at 5:54 PM, Ram Pai wrote: > On Wed, Jul 11, 2012 at 02:06:10PM +0300, Purdila, Octavian wrote: >> On Wed, Jul 11, 2012 at 5:09 AM, Ram Pai wrote: >> >> > >> > Wait.. I am not sure this will fix the problem entirely. The above check >> > will handle the case where the range r

Re: [PATCH] resource: make sure requested range intersects root range

2012-07-11 Thread Ram Pai
On Wed, Jul 11, 2012 at 02:06:10PM +0300, Purdila, Octavian wrote: > On Wed, Jul 11, 2012 at 5:09 AM, Ram Pai wrote: > > > > > Wait.. I am not sure this will fix the problem entirely. The above check > > will handle the case where the range requested is entirey out of the > > root's range. But i

Re: [PATCH] resource: make sure requested range intersects root range

2012-07-11 Thread Purdila, Octavian
On Wed, Jul 11, 2012 at 5:09 AM, Ram Pai wrote: > > Wait.. I am not sure this will fix the problem entirely. The above check > will handle the case where the range requested is entirey out of the > root's range. But if the requested range overlapps that of the root > range, we will still call __

Re: [PATCH] resource: make sure requested range intersects root range

2012-07-10 Thread Ram Pai
On Tue, Jul 10, 2012 at 02:33:48PM -0700, Andrew Morton wrote: > On Sat, 30 Jun 2012 15:00:57 +0300 > Octavian Purdila wrote: > > > When the requested and root ranges do not intersect the logic in > > __reserve_region_with_split will cause an infinite recursion which > > will overflow the stack a

Re: [PATCH] resource: make sure requested range intersects root range

2012-07-10 Thread Joe Perches
On Tue, 2012-07-10 at 14:33 -0700, Andrew Morton wrote: > On Sat, 30 Jun 2012 15:00:57 +0300 > Octavian Purdila wrote: > > > When the requested and root ranges do not intersect the logic in > > __reserve_region_with_split will cause an infinite recursion which > > will overflow the stack as seen

Re: [PATCH] resource: make sure requested range intersects root range

2012-07-10 Thread Andrew Morton
On Sat, 30 Jun 2012 15:00:57 +0300 Octavian Purdila wrote: > When the requested and root ranges do not intersect the logic in > __reserve_region_with_split will cause an infinite recursion which > will overflow the stack as seen in the warning bellow. > > This particular stack overflow was cause