Re: [PATCH] revert ath5k ioread32()/iowrite32() usage - use readl()/writel(), we're MMIO-only

2007-09-18 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: To be more precise, a platform has every right to return some kind of "token" from ioport_map/pci_iomap that encodes the type of address, and that is -different- from what a normal ioremap does. In which case, you will -not- be able to use readb/writeb & cie on such

Re: [PATCH] revert ath5k ioread32()/iowrite32() usage - use readl()/writel(), we're MMIO-only

2007-09-18 Thread Benjamin Herrenschmidt
> > > > If the driver knows its MMIO, using readX/writeX after pci_iomap() is > > > > just fine, for all current implementations, and it makes sense that way. > > > > > > There is nothing that guarantees this is permitted, any more than there > > > is anything saying not to use outb/outl. Some of

Re: [PATCH] revert ath5k ioread32()/iowrite32() usage - use readl()/writel(), we're MMIO-only

2007-09-18 Thread Luis R. Rodriguez
On 9/18/07, Luis R. Rodriguez <[EMAIL PROTECTED]> wrote: > On 9/17/07, Jiri Slaby <[EMAIL PROTECTED]> wrote: > > On 09/17/2007 10:59 PM, Jeff Garzik wrote: > > > Jiri Slaby wrote: > > >> NACK, this is wrong. iomap returns platform dependant return value, > > >> which may or > > > > > > Incorrect.

Re: [PATCH] revert ath5k ioread32()/iowrite32() usage - use readl()/writel(), we're MMIO-only

2007-09-18 Thread Luis R. Rodriguez
On 9/17/07, Jiri Slaby <[EMAIL PROTECTED]> wrote: > On 09/17/2007 10:59 PM, Jeff Garzik wrote: > > Jiri Slaby wrote: > >> NACK, this is wrong. iomap returns platform dependant return value, > >> which may or > > > > Incorrect. readl() and writel() work just fine on all existing > > platforms where

Re: [PATCH] revert ath5k ioread32()/iowrite32() usage - use readl()/writel(), we're MMIO-only

2007-09-17 Thread Jiri Slaby
On 09/17/2007 10:59 PM, Jeff Garzik wrote: > Jiri Slaby wrote: >> NACK, this is wrong. iomap returns platform dependant return value, >> which may or > > Incorrect. readl() and writel() work just fine on all existing > platforms where Atheros may be used. Ok, this is what Alan Cox wrote about th