Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-04-11 Thread Palmer Dabbelt
On Mon, 29 Mar 2021 11:16:24 PDT (-0700), jszha...@mail.ustc.edu.cn wrote: From: Jisheng Zhang Current riscv's kprobe handlers are run with both preemption and interrupt enabled, this violates kprobe requirements. Fix this issue by keeping interrupts disabled for BREAKPOINT exception. Fixes:

Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-04-08 Thread Maciej W. Rozycki
On Fri, 9 Apr 2021, Masami Hiramatsu wrote: > > > Is this approach guaranteed to keep interrupt handling latency low enough > > > for the system not to be negatively affected, e.g. for the purpose of NTP > > > timekeeping? > > > > IMHO, interrupt latency can't be ensured if kprobes is

Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-04-08 Thread Masami Hiramatsu
On Thu, 8 Apr 2021 19:23:48 +0800 Jisheng Zhang wrote: > On Sat, 3 Apr 2021 20:30:53 +0200 (CEST) > "Maciej W. Rozycki" wrote: > > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > > > > On

Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-04-08 Thread Jisheng Zhang
On Sat, 3 Apr 2021 20:30:53 +0200 (CEST) "Maciej W. Rozycki" wrote: > CAUTION: Email originated externally, do not click links or open attachments > unless you recognize the sender and know the content is safe. > > > On Thu, 1 Apr 2021, Masami Hiramatsu wrote: > > > > > > Current riscv's

Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-04-06 Thread liaochang (A)
Hi Jisheng, 在 2021/4/2 21:32, Jisheng Zhang 写道: > On Thu, 1 Apr 2021 16:49:47 +0800 > "liaochang (A)" wrote: > >> Hi Jisheng, > > Hi, > >> >> 在 2021/3/31 22:22, Jisheng Zhang 写道: >>> On Tue, 30 Mar 2021 18:33:16 +0900 >>> Masami Hiramatsu wrote: >>> Hi Jisheng, >>> >>> Hi Masami,

Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-04-03 Thread Maciej W. Rozycki
On Thu, 1 Apr 2021, Masami Hiramatsu wrote: > > > > Current riscv's kprobe handlers are run with both preemption and > > > > interrupt enabled, this violates kprobe requirements. Fix this issue > > > > by keeping interrupts disabled for BREAKPOINT exception. > > > > > > Not only while the

Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-04-02 Thread Jisheng Zhang
On Thu, 1 Apr 2021 16:49:47 +0800 "liaochang (A)" wrote: > Hi Jisheng, Hi, > > 在 2021/3/31 22:22, Jisheng Zhang 写道: > > On Tue, 30 Mar 2021 18:33:16 +0900 > > Masami Hiramatsu wrote: > > > >> Hi Jisheng, > > > > Hi Masami, > > > >> > >> On Tue, 30 Mar 2021 02:16:24 +0800 > >>

Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-04-01 Thread liaochang (A)
Hi Jisheng, 在 2021/3/31 22:22, Jisheng Zhang 写道: > On Tue, 30 Mar 2021 18:33:16 +0900 > Masami Hiramatsu wrote: > >> Hi Jisheng, > > Hi Masami, > >> >> On Tue, 30 Mar 2021 02:16:24 +0800 >> Jisheng Zhang wrote: >> >>> From: Jisheng Zhang >>> >>> Current riscv's kprobe handlers are run with

Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-03-31 Thread Masami Hiramatsu
Hi, On Wed, 31 Mar 2021 22:22:44 +0800 Jisheng Zhang wrote: > On Tue, 30 Mar 2021 18:33:16 +0900 > Masami Hiramatsu wrote: > > > Hi Jisheng, > > Hi Masami, > > > > > On Tue, 30 Mar 2021 02:16:24 +0800 > > Jisheng Zhang wrote: > > > > > From: Jisheng Zhang > > > > > > Current riscv's

Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-03-31 Thread Jisheng Zhang
On Tue, 30 Mar 2021 18:33:16 +0900 Masami Hiramatsu wrote: > Hi Jisheng, Hi Masami, > > On Tue, 30 Mar 2021 02:16:24 +0800 > Jisheng Zhang wrote: > > > From: Jisheng Zhang > > > > Current riscv's kprobe handlers are run with both preemption and > > interrupt enabled, this violates kprobe

Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-03-30 Thread Masami Hiramatsu
Hi Jisheng, On Tue, 30 Mar 2021 02:16:24 +0800 Jisheng Zhang wrote: > From: Jisheng Zhang > > Current riscv's kprobe handlers are run with both preemption and > interrupt enabled, this violates kprobe requirements. Fix this issue > by keeping interrupts disabled for BREAKPOINT exception. Not

[PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-03-29 Thread Jisheng Zhang
From: Jisheng Zhang Current riscv's kprobe handlers are run with both preemption and interrupt enabled, this violates kprobe requirements. Fix this issue by keeping interrupts disabled for BREAKPOINT exception. Fixes: c22b0bcb1dd0 ("riscv: Add kprobes supported") Signed-off-by: Jisheng Zhang