Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-10-17 Thread Christoph Hellwig
Mauro, can you Ack this patch? On Sat, Sep 28, 2019 at 12:53:04AM +0200, Christoph Hellwig wrote: > > > well enough myself, and I really need to get this code out of the > > > forced on RISC-V codebase as some SOCs I'm working with simply don't > > > have the memory for it.. > > > > > > So unless

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-09-27 Thread Christoph Hellwig
On Thu, Aug 22, 2019 at 06:26:35AM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 19 Aug 2019 08:26:19 +0200 > Christoph Hellwig escreveu: > > > On Mon, Aug 19, 2019 at 08:09:04AM +0200, Borislav Petkov wrote: > > > On Sun, Aug 18, 2019 at 10:29:35AM +0200, Christoph Hellwig wrote: > > > > The s

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-09-06 Thread Christoph Hellwig
On Fri, Sep 06, 2019 at 03:33:02PM -0700, Paul Walmsley wrote: > If that's your primary concern, then in the short term, how about just > sending a single-line patch to the arch/riscv/mm Makefile to skip building > it if !CONFIG_SOC_SIFIVE? Assuming, that is, you won't be enabling EDAC > suppor

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-09-06 Thread Christoph Hellwig
On Fri, Sep 06, 2019 at 03:36:09PM -0700, Paul Walmsley wrote: > One other comment on this patch: > > On Fri, 6 Sep 2019, Paul Walmsley wrote: > > > On Sun, 18 Aug 2019, Christoph Hellwig wrote: > > > > > diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig > > > index 200c04ce5b0e..9241b3e7a

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-09-06 Thread Christoph Hellwig
On Fri, Sep 06, 2019 at 03:27:44PM -0700, Paul Walmsley wrote: > - Since the patch doesn't fix any bugs, there shouldn't be a Fixes: line. > Please let me know whether I can drop the line locally before I apply the > patch, or whether you'd like to resend it. It fixes the bug that we build code

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-09-06 Thread Paul Walmsley
One other comment on this patch: On Fri, 6 Sep 2019, Paul Walmsley wrote: > On Sun, 18 Aug 2019, Christoph Hellwig wrote: > > > diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig > > index 200c04ce5b0e..9241b3e7a050 100644 > > --- a/drivers/edac/Kconfig > > +++ b/drivers/edac/Kconfig > > @@

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-09-06 Thread Paul Walmsley
On Mon, 19 Aug 2019, Christoph Hellwig wrote: > On Mon, Aug 19, 2019 at 08:09:04AM +0200, Borislav Petkov wrote: > > On Sun, Aug 18, 2019 at 10:29:35AM +0200, Christoph Hellwig wrote: > > > The sifive_l2_cache.c is in no way related to RISC-V architecture > > > memory management. It is a little s

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-09-06 Thread Paul Walmsley
On Sun, 18 Aug 2019, Christoph Hellwig wrote: > The sifive_l2_cache.c is in no way related to RISC-V architecture > memory management. It is a little stub driver working around the fact > that the EDAC maintainers prefer their drivers to be structured in a > certain way that doesn't fit the SiFiv

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-09-01 Thread Christoph Hellwig
On Fri, Aug 30, 2019 at 07:53:17PM -0700, Paul Walmsley wrote: > There's already a MAINTAINERS entry that should cover drivers/soc/sifive. > Probably it's not needed to add another one here. So are you going to apply the original patch to the riscv tree? I dont want to keep this file lingering a

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-08-30 Thread Paul Walmsley
Hi Mauro, On Thu, 22 Aug 2019, Mauro Carvalho Chehab wrote: > I'm wandering if we should at least add an entry for this one at > MAINTAINERS, pointing it to the EDAC mailing list. Something like: > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7dfe381c8b43..1c3bc5aa3af0 100644 > --- a/MAINTAI

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-08-22 Thread Mauro Carvalho Chehab
Em Mon, 19 Aug 2019 08:26:19 +0200 Christoph Hellwig escreveu: > On Mon, Aug 19, 2019 at 08:09:04AM +0200, Borislav Petkov wrote: > > On Sun, Aug 18, 2019 at 10:29:35AM +0200, Christoph Hellwig wrote: > > > The sifive_l2_cache.c is in no way related to RISC-V architecture > > > memory managemen

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-08-19 Thread Yash Shah
On Mon, Aug 19, 2019 at 11:56 AM Christoph Hellwig wrote: > > On Mon, Aug 19, 2019 at 08:09:04AM +0200, Borislav Petkov wrote: > > On Sun, Aug 18, 2019 at 10:29:35AM +0200, Christoph Hellwig wrote: > > > The sifive_l2_cache.c is in no way related to RISC-V architecture > > > memory management. It

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-08-18 Thread Christoph Hellwig
On Mon, Aug 19, 2019 at 08:09:04AM +0200, Borislav Petkov wrote: > On Sun, Aug 18, 2019 at 10:29:35AM +0200, Christoph Hellwig wrote: > > The sifive_l2_cache.c is in no way related to RISC-V architecture > > memory management. It is a little stub driver working around the fact > > that the EDAC ma

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-08-18 Thread Borislav Petkov
On Sun, Aug 18, 2019 at 10:29:35AM +0200, Christoph Hellwig wrote: > The sifive_l2_cache.c is in no way related to RISC-V architecture > memory management. It is a little stub driver working around the fact > that the EDAC maintainers prefer their drivers to be structured in a > certain way That

Re: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-08-18 Thread Anup Patel
On Sun, Aug 18, 2019 at 2:01 PM Christoph Hellwig wrote: > > The sifive_l2_cache.c is in no way related to RISC-V architecture > memory management. It is a little stub driver working around the fact > that the EDAC maintainers prefer their drivers to be structured in a > certain way that doesn't

[PATCH] riscv: move sifive_l2_cache.c to drivers/soc

2019-08-18 Thread Christoph Hellwig
The sifive_l2_cache.c is in no way related to RISC-V architecture memory management. It is a little stub driver working around the fact that the EDAC maintainers prefer their drivers to be structured in a certain way that doesn't fit the SiFive SOCs. Move the file to drivers/soc and add a Kconfig