Re: [PATCH] rlim in proc/pid/status (2nd rev.)

2008-01-16 Thread Clifford Wolf
Hi, On Wed, Jan 16, 2008 at 04:33:12PM +0900, KOSAKI Motohiro wrote: Hi Clifford, +static inline char *task_rlim(struct task_struct *p, char *buffer) +{ + unsigned long flags; + struct rlimit rlim[RLIM_NLIMITS]; + int i; + + rcu_read_lock(); + if

Re: [PATCH] rlim in proc/pid/status (2nd rev.)

2008-01-15 Thread Clifford Wolf
Hi, On Tue, Jan 15, 2008 at 02:36:59PM -0600, [EMAIL PROTECTED] wrote: + rcu_read_lock(); + if (lock_task_sighand(p, flags)) { + for (i=0; iRLIM_NLIMITS; i++) + rlim[i] = p-signal-rlim[i]; I'm confused - where do you unlock_task_sighand()? oh fsck!

Re: [PATCH] rlim in proc/pid/status (2nd rev.)

2008-01-15 Thread KOSAKI Motohiro
Hi Clifford, +static inline char *task_rlim(struct task_struct *p, char *buffer) +{ + unsigned long flags; + struct rlimit rlim[RLIM_NLIMITS]; + int i; + + rcu_read_lock(); + if (lock_task_sighand(p, flags)) { + for (i=0; iRLIM_NLIMITS; i++) +